Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -295,26 +295,25 @@
<plugin>
<groupId>pl.project13.maven</groupId>
<artifactId>git-commit-id-plugin</artifactId>
<version>2.2.4</version>
<version>4.9.10</version>
<executions>
<execution>
<id>get-the-git-infos</id>
<goals>
<goal>revision</goal>
</goals>
<phase>initialize</phase>
</execution>
</executions>
<configuration>
<dotGitDirectory>${project.basedir}/.git</dotGitDirectory>
<prefix>git</prefix>
<verbose>false</verbose>
<generateGitPropertiesFile>true</generateGitPropertiesFile>
<generateGitPropertiesFilename>
${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
<format>json</format>
<gitDescribe>
<skip>true</skip>
</gitDescribe>
<generateGitPropertiesFilename>${project.build.outputDirectory}/git.properties</generateGitPropertiesFilename>
<includeOnlyProperties>
<includeOnlyProperty>git.commit.id</includeOnlyProperty>
<includeOnlyProperty>git.build.time</includeOnlyProperty>
</includeOnlyProperties>
<commitIdGenerationMode>full</commitIdGenerationMode>
<format>properties</format>
</configuration>
</plugin>
<plugin>
Expand Down Expand Up @@ -472,6 +471,12 @@
<goal>repackage</goal>
</goals>
</execution>
<execution>
<id>build-info</id>
<goals>
<goal>build-info</goal>
</goals>
</execution>
</executions>
</plugin>
</plugins>
Expand All @@ -485,4 +490,4 @@
</plugin>
</plugins>
</reporting>
</project>
</project>
33 changes: 33 additions & 0 deletions src/main/java/com/iemr/admin/config/SecurityFilterConfig.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.iemr.admin.config;

import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.beans.factory.annotation.Value;
import org.springframework.boot.web.servlet.FilterRegistrationBean;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;

import com.iemr.admin.utils.JwtAuthenticationUtil;
import com.iemr.admin.utils.JwtUserIdValidationFilter;

@Configuration
public class SecurityFilterConfig {

@Autowired
private JwtAuthenticationUtil jwtAuthenticationUtil;

@Value("${cors.allowed-origins}")
private String allowedOrigins;

@Bean
public FilterRegistrationBean<JwtUserIdValidationFilter> jwtFilterRegistration() {
FilterRegistrationBean<JwtUserIdValidationFilter> registration = new FilterRegistrationBean<>();
registration.setFilter(new JwtUserIdValidationFilter(jwtAuthenticationUtil, allowedOrigins));
registration.addUrlPatterns("/*");
registration.setOrder(1);

// Set name for easier debugging
registration.setName("JwtUserIdValidationFilter");

return registration;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
/*
* AMRIT – Accessible Medical Records via Integrated Technology
* Integrated EHR (Electronic Health Records) Solution
*
* Copyright (C) "Piramal Swasthya Management and Research Institute"
*
* This file is part of AMRIT.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see https://www.gnu.org/licenses/.
*/
package com.iemr.admin.controller.health;

import java.util.Map;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RestController;

import com.iemr.admin.service.health.HealthService;

import io.swagger.v3.oas.annotations.Operation;

@RestController
public class HealthController {

private static final Logger logger = LoggerFactory.getLogger(HealthController.class);

@Autowired
private HealthService healthService;

@Operation(summary = "Health check endpoint")
@GetMapping("/health")
public ResponseEntity<Map<String, Object>> health() {
logger.info("Health check endpoint called");

Map<String, Object> healthStatus = healthService.checkHealth();

// Return 503 if any service is down, 200 if all are up
String status = (String) healthStatus.get("status");
HttpStatus httpStatus = "UP".equals(status) ? HttpStatus.OK : HttpStatus.SERVICE_UNAVAILABLE;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Suraj-kumar00
If Redis/DB has issues, we get failure on hitting /health.

Can we instead return a JSON.
With the current implementation, how do I know which underlying service is broken?

Missed this earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me work on this @drtechie, will update you.


logger.info("Health check completed with status: {}", status);
return ResponseEntity.status(httpStatus).body(healthStatus);
}
}
Copy link
Member

@vishwab1 vishwab1 Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can move the logic (like reading Git properties and building the JSON) into a separate service method instead of writing everything inside the controller. Also, let’s review all the suggestions given by CodeRabbit once again. One of the points to check is the use of StringBuilder, as it might cause issues in some cases.

Original file line number Diff line number Diff line change
Expand Up @@ -21,58 +21,33 @@
*/
package com.iemr.admin.controller.version;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.util.Map;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

import org.springframework.web.bind.annotation.RequestMapping;
import org.springframework.web.bind.annotation.RequestMethod;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.http.MediaType;
import org.springframework.web.bind.annotation.GetMapping;
import org.springframework.web.bind.annotation.RestController;

import com.iemr.admin.utils.response.OutputResponse;
import com.iemr.admin.service.version.VersionService;

import io.swagger.v3.oas.annotations.Operation;


@RestController
public class VersionController {

private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName());

@Operation(summary = "Version information")
@RequestMapping(value = "/version", method = { RequestMethod.GET })
public String versionInformation() {
OutputResponse output = new OutputResponse();
try {
logger.info("version Controller Start");
output.setResponse(readGitProperties());
} catch (Exception e) {
output.setError(e);
}

logger.info("version Controller End");
return output.toString();
}

private String readGitProperties() throws Exception {
ClassLoader classLoader = getClass().getClassLoader();
InputStream inputStream = classLoader.getResourceAsStream("git.properties");
private static final Logger logger = LoggerFactory.getLogger(VersionController.class);

return readFromInputStream(inputStream);
}
@Autowired
private VersionService versionService;

private String readFromInputStream(InputStream inputStream) throws IOException {
StringBuilder resultStringBuilder = new StringBuilder();
try (BufferedReader br = new BufferedReader(new InputStreamReader(inputStream))) {
String line;
while ((line = br.readLine()) != null) {
resultStringBuilder.append(line).append("\n");
}
}
return resultStringBuilder.toString();
}
@Operation(summary = "Version information")
@GetMapping(value = "/version", produces = MediaType.APPLICATION_JSON_VALUE)
public Map<String, String> versionInformation() {
logger.info("version Controller Start");
Map<String, String> versionInfo = versionService.getVersionInfo();
logger.info("version Controller End");
return versionInfo;
}
}
119 changes: 119 additions & 0 deletions src/main/java/com/iemr/admin/service/health/HealthService.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,119 @@
/*
* AMRIT – Accessible Medical Records via Integrated Technology
* Integrated EHR (Electronic Health Records) Solution
*
* Copyright (C) "Piramal Swasthya Management and Research Institute"
*
* This file is part of AMRIT.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program. If not, see https://www.gnu.org/licenses/.
*/
package com.iemr.admin.service.health;

import java.sql.Connection;
import java.sql.PreparedStatement;
import java.sql.ResultSet;
import java.util.HashMap;
import java.util.Map;

import javax.sql.DataSource;

import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.data.redis.core.RedisCallback;
import org.springframework.data.redis.core.RedisTemplate;
import org.springframework.stereotype.Service;

@Service
public class HealthService {

private static final Logger logger = LoggerFactory.getLogger(HealthService.class);
private static final String DB_HEALTH_CHECK_QUERY = "SELECT 1 as health_check";

@Autowired
private DataSource dataSource;

@Autowired(required = false)
private RedisTemplate<String, Object> redisTemplate;
Comment on lines +48 to +49
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | πŸ”΄ Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Find all RedisTemplate bean definitions and analyze duplicate beans

echo "=== Searching for RedisTemplate @Bean definitions ==="
rg -n -B 2 -A 5 '@Bean.*RedisTemplate|@Bean.*redisTemplate' --type java

echo -e "\n=== Searching for any RedisTemplate bean creation ==="
rg -n -B 2 -A 5 'RedisTemplate.*new.*|return.*RedisTemplate' --type java

echo -e "\n=== Checking RoleMasterApplication class ==="
fd 'RoleMasterApplication' --type f | head -5 | xargs -I {} sh -c 'echo "=== {} ===" && cat -n {}'

echo -e "\n=== Checking RedisConfig class ==="
fd 'RedisConfig' --type f | head -5 | xargs -I {} sh -c 'echo "=== {} ===" && cat -n {}'

echo -e "\n=== Checking application properties for Redis pool config ==="
fd 'application.*properties' --type f | xargs -I {} sh -c 'echo "=== {} ===" && rg "redis|pool" {} -i'

echo -e "\n=== Checking HealthService imports and annotation ==="
head -60 src/main/java/com/iemr/admin/service/health/HealthService.java | cat -n

Repository: PSMRI/Admin-API

Length of output: 9443


Resolve duplicate RedisTemplate bean definitions.

Two @bean methods create redisTemplate beans with the same name in RoleMasterApplication and RedisConfig, causing Spring startup failure. HealthService cannot inject the correct bean without disambiguation.

Immediate fix: Add @Qualifier to specify the intended bean:

 @Autowired(required = false)
+@Qualifier("redisTemplate")
 private RedisTemplate<String, Object> redisTemplate;

Long-term: Rename or remove one conflicting bean definition. RoleMasterApplication creates RedisTemplate<String, Object> (matches HealthService), while RedisConfig creates RedisTemplate<String, M_User>. Determine which is actually needed elsewhere and either rename one or consolidate the configurations.

Also add missing Redis connection pool configuration to application.properties:

spring.redis.lettuce.pool.max-active=8
spring.redis.lettuce.pool.max-idle=8
spring.redis.lettuce.pool.min-idle=0
πŸ€– Prompt for AI Agents
In src/main/java/com/iemr/admin/service/health/HealthService.java around lines
48-49, the class autowires a RedisTemplate without disambiguation while two
beans with the same type/name exist, causing startup failures; update the field
injection to use @Qualifier referencing the exact bean name you intend (the one
declared in RoleMasterApplication or the one in RedisConfig) so Spring injects
the correct RedisTemplate, and as a long-term fix rename or remove the duplicate
bean definition (or change one bean name/type to RedisTemplate<String, M_User>
accordingly) to avoid conflicts; additionally add the suggested Redis Lettuce
pool properties to application.properties: spring.redis.lettuce.pool.max-active,
spring.redis.lettuce.pool.max-idle, and spring.redis.lettuce.pool.min-idle with
the provided values.


public Map<String, Object> checkHealth() {
Map<String, Object> healthStatus = new HashMap<>();
boolean overallHealth = true;

// Check database connectivity (details logged internally, not exposed)
boolean dbHealthy = checkDatabaseHealthInternal();
if (!dbHealthy) {
overallHealth = false;
}

// Check Redis connectivity if configured (details logged internally)
if (redisTemplate != null) {
boolean redisHealthy = checkRedisHealthInternal();
if (!redisHealthy) {
overallHealth = false;
}
}

healthStatus.put("status", overallHealth ? "UP" : "DOWN");

logger.info("Health check completed - Overall status: {}", overallHealth ? "UP" : "DOWN");
return healthStatus;
}

private boolean checkDatabaseHealthInternal() {
long startTime = System.currentTimeMillis();

try (Connection connection = dataSource.getConnection()) {
boolean isConnectionValid = connection.isValid(2); // 2 second timeout per best practices

if (isConnectionValid) {
try (PreparedStatement stmt = connection.prepareStatement(DB_HEALTH_CHECK_QUERY)) {
stmt.setQueryTimeout(3); // 3 second query timeout
try (ResultSet rs = stmt.executeQuery()) {
if (rs.next() && rs.getInt(1) == 1) {
long responseTime = System.currentTimeMillis() - startTime;
logger.debug("Database health check: UP ({}ms)", responseTime);
return true;
}
}
}
}
logger.warn("Database health check: Connection not valid");
return false;
} catch (Exception e) {
logger.error("Database health check failed: {}", e.getMessage());
return false;
}
}

private boolean checkRedisHealthInternal() {
long startTime = System.currentTimeMillis();

try {
String pong = redisTemplate.execute((RedisCallback<String>) connection -> connection.ping());

if ("PONG".equals(pong)) {
long responseTime = System.currentTimeMillis() - startTime;
logger.debug("Redis health check: UP ({}ms)", responseTime);
return true;
}
logger.warn("Redis health check: Ping returned unexpected response");
return false;
} catch (Exception e) {
logger.error("Redis health check failed: {}", e.getMessage());
return false;
}
}
}
Loading
Loading