fix(linting): fixed linting to handle linting for JAVA and XML files by Zapper9982 · Pull Request #122 · PSMRI/HWC-API

Zapper9982 · 2025-04-25T15:30:30Z

📋 Description

JIRA ID:

Updated the linting to handle .java and .xml files

added Checkstyle.jar which allows linting for .java files
xmllint for linting xml files

✅ Type of Change

Screenshots

Summary by CodeRabbit

Chores
- Updated linting configuration to include checks for XML files alongside existing TypeScript and JavaScript linting.

coderabbitai · 2025-04-25T15:30:36Z

Walkthrough

The changes update the lint-staged configuration within the package.json file. The linting file patterns were revised to focus on TypeScript and JavaScript files only, removing CSS and HTML from the ESLint targets. Additionally, a new linting command was added to validate XML files project-wide using xmllint --noout. This expands pre-commit linting to include XML syntax validation alongside existing ESLint checks for TypeScript and JavaScript files.

Changes

File(s)	Change Summary
package.json	Updated lint-staged configuration: changed ESLint file patterns to target TypeScript and JavaScript only; added xmllint command for XML file validation.

Poem

🐇 Hopping through code with delight,
XML joins the linting flight.
TypeScript and JS keep their place,
Clean code now wins the race!
With xmllint’s sharp eye,
No broken tags slip by!
✨📜🐰

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 12e6972 and 1db3d41.

📒 Files selected for processing (1)

package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (java)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf084a1 and 884d960.

⛔ Files ignored due to path filters (1)

checkstyle.jar is excluded by !**/*.jar

📒 Files selected for processing (1)

package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (java)

🔇 Additional comments (1)

package.json (1)

16-18: Verify ESLint patterns for TypeScript/JavaScript and removed file types
The glob "src/**/*.{ts,js}" now only targets .ts and .js. Confirm that dropping .css and .html from your ESLint step is intentional—if you still need to lint those files, you’ll want to reintroduce them or wire up stylelint/HTMLLint. Also consider whether you need to include .jsx/.tsx.

package.json

drtechie · 2025-05-01T07:09:50Z

checkstyle.jar

@Zapper9982 let's not commit binary files

okay! @drtechie should i figure out thje checkstyle.xml configuration to have linting implemented then ?

sonarqubecloud · 2025-05-01T07:37:22Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix(linting): fixed linting to handle linting for JAVA and XML files

884d960

coderabbitai bot reviewed Apr 25, 2025

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

fix(lint): fixed according to coderabbit

12e6972

drtechie reviewed May 1, 2025

View reviewed changes

fix(rem): removed linting for java files temporarily

1db3d41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(linting): fixed linting to handle linting for JAVA and XML files#122

fix(linting): fixed linting to handle linting for JAVA and XML files#122
Zapper9982 wants to merge 3 commits intoPSMRI:developfrom
Zapper9982:fix/linting

Zapper9982 commented Apr 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

drtechie May 1, 2025

Uh oh!

Zapper9982 May 1, 2025

Uh oh!

sonarqubecloud bot commented May 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Zapper9982 commented Apr 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Description

✅ Type of Change

Screenshots

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

drtechie May 1, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 May 1, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 1, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Zapper9982 commented Apr 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)