Prevent async projectile owner lookup during world gen#13643
Closed
HaHaWTH wants to merge 1 commit intoPaperMC:mainfrom
Closed
Prevent async projectile owner lookup during world gen#13643HaHaWTH wants to merge 1 commit intoPaperMC:mainfrom
HaHaWTH wants to merge 1 commit intoPaperMC:mainfrom
Conversation
Contributor
|
Related to #13481 |
Member
|
Superceded by 4c91cd3 |
github-project-automation
bot
moved this from Awaiting review
to Closed
in Paper PR Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13475.
Saved structures with projectile entity inside (some datapack structures) will cause AsyncCatcher to throw an exception.
After skipping the bukkit owner lookup in worldgen, it will be handled by CB's AbstractProjecile#getShooter. So it shouldn't cause plugin behavior inconsistencies.