Conversation
DavidBoike
force-pushed
the
testing
branch
2 times, most recently
from
152f36d to
70ae333
Compare
… run befor function triggers starts to process messages
DavidBoike
requested review from
andreasohlund,
danielmarbach and
mattmercurio
|
Agreed, we should add another overload!
…On Tuesday, February 17, 2026, David Boike ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/IntegrationTest/Infrastructure/TestStorageFeature.cs
<#16 (comment)>
:
> + context.Services.AddSingleton<IncomingTestBehavior>();
+ context.Services.AddSingleton<OutgoingTestBehavior>();
+
+ context.Pipeline.Register("IncomingTestBehavior", p => p.GetRequiredService<IncomingTestBehavior>(), "Log received messages");
+ context.Pipeline.Register("OutgoingTestBehavior", p => p.GetRequiredService<OutgoingTestBehavior>(), "Forward test case name to outgoing messages");
Because I was only looking at the strongly typed Register<T>() overloads.
Isn't it really weird there is no Register<TBehavior>(string description)
option?
—
Reply to this email directly, view it on GitHub
<#16 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA6QZCV5S65LC5MP2R26PD4MNU3ZAVCNFSM6AAAAACURHMXGOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQMJVHEYTCOJWGE>
.
You are receiving this because your review was requested.Message ID:
***@***.***
com>
|
danielmarbach
left a comment
danielmarbach
left a comment
There was a problem hiding this comment.
I think this looks like an approach we can use to have a few real functions we use to test that everything works properly. It might be beneficial to use something like Microsoft.Extensions.Http and a small DI container / ServiceCollection to simplify wiring of the Http Client and some other things we can "improve" but I like this as a prototype. I have a few more questions / thoughts I'll bring up internally
|
|
||
| public static ExceptionInfo[] GetErrors() | ||
| { | ||
| while (collectedExceptions.Count > 20) |
There was a problem hiding this comment.
Why do we only propagate the last twenty?
There was a problem hiding this comment.
Only so that it doesn't grow out of control and make it difficult to download an over-large JSON blob. Picked a random number. 🤷
| } | ||
| } | ||
|
|
||
| public static ExceptionInfo[] GetErrors() |
There was a problem hiding this comment.
Out of curiosity, why not https://learn.microsoft.com/en-us/dotnet/api/system.runtime.exceptionservices.exceptiondispatchinfo? Is it because we want to serialize and we do not care about capturing the exception and freeze the stack trace?
There was a problem hiding this comment.
I only care about seeing the app exceptions in the test output to be able to diagnose issues.
|
Needs a rebase. After that this seems good to go. Since we decided to only have a few of those tests it is probably not worth investing more time in polishing it. |
|
Replaced by #31 due to merge conflict issues |
3 participants
No description provided.