Fix: Properly resolve virtual kernel meta-packages to actual kernel versions#40
Closed
romprod wants to merge 1 commit intoPatchMon:mainfrom
Closed
Fix: Properly resolve virtual kernel meta-packages to actual kernel versions#40romprod wants to merge 1 commit intoPatchMon:mainfrom
romprod wants to merge 1 commit intoPatchMon:mainfrom
Conversation
…ersions Fixes #379 Fixes #390 Issue: Virtual kernel meta-packages (linux-image-virtual, linux-image-generic, etc.) were incorrectly marked as needs_reboot=true because the agent compared the meta-package name against the running kernel version instead of the actual kernel the meta-package depends on. Root Cause: - Agent extracted meta-package name: 'virtual' - Compared against running kernel: '5.15.0-164-generic' - Mismatch triggered false positive needs_reboot=true Solution: - Expanded meta-package detection to cover all variants - Added resolveMetaPackageKernel() to resolve meta-packages to actual kernels - Uses apt-cache depends to find kernel dependencies - Gracefully falls back if apt-cache unavailable (non-Debian systems) Changes: - Modified getLatestKernelFromDpkg() in internal/system/reboot.go - Now skips: virtual, generic, lowlatency, cloud, generic-hwe meta-packages - Resolves each meta-package to its actual kernel package - Added resolveMetaPackageKernel() function - Queries apt-cache for package dependencies - Parses kernel package information - Logs resolution attempts for debugging - Added comprehensive tests in internal/system/reboot_test.go - 22+ test cases covering parsing, comparison, and edge cases - Tests for all known meta-package variants - Tests for missing/unavailable apt-cache fallback Impact: - Affects: Ubuntu/Debian systems with virtual kernel meta-packages - Risk: Low - only changes reboot detection logic - Backward compatible: Non-meta-package systems unaffected - Performance: No impact
Collaborator
|
Partially implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes false positive reboot detection (#379, #390) where systems with virtual kernel meta-packages were incorrectly flagged as needing a reboot.
Problem
Virtual kernel meta-packages like
linux-image-virtualandlinux-image-genericwere being compared directly against the running kernel version, causing mismatches:virtual(meta-package name)5.15.0-164-generic(actual kernel)needs_reboot=trueSolution
Enhanced meta-package detection in
getLatestKernelFromDpkg()New
resolveMetaPackageKernel()functionapt-cache dependsto query meta-package dependenciesComprehensive test coverage in new
internal/system/reboot_test.goImpact
Files Changed
internal/system/reboot.go- Enhanced kernel detection logic (+116 lines)internal/system/reboot_test.go- New comprehensive test suite (229 lines)Testing
Run tests with:
go test -v ./internal/systemFixes #379 Fixes #390