Skip to content

Comments

Add search bar and navigation to Notes tab#1770

Open
Nostyxx wants to merge 5 commits intoPathOfBuildingCommunity:devfrom
Nostyxx:notes-search-feature
Open

Add search bar and navigation to Notes tab#1770
Nostyxx wants to merge 5 commits intoPathOfBuildingCommunity:devfrom
Nostyxx:notes-search-feature

Conversation

@Nostyxx
Copy link

@Nostyxx Nostyxx commented Feb 21, 2026

Fixes #1670

Description of the problem being solved:

Implements a dedicated search bar and navigation buttons for the Notes tab.

Steps taken to verify a working solution:

Verified that searching matches text correctly across multiple lines.
Verified that the search correctly wraps around from bottom-to-top and top-to-bottom.
Verified that the search ignores all variations of PoB color codes.
Verified that navigation buttons and shortcuts correctly cycle through matches.

Before screenshot:

image

After screenshot:

image image

@Blitz54
Copy link
Contributor

Blitz54 commented Feb 21, 2026

image

Highlighting the text makes the rest of the line print in white too.
EDIT: Apparently that's an issue on current release. Would be nice to fix tho.

Also would be nice if clicking the search box would highlight the previously highlighted text, or at least the first one. Atm clicking the notes box, then the search box, will have nothing highlighted. So either need to add or subtract a letter, or press the next/previous button.

EDIT EDIT:

				local selWidth = DrawStringWidth(textHeight, self.font, sel)
				local r,g,b,a = GetDrawColor()
				SetDrawColor(self.selBGCol)
				DrawImage(nil, textX, textY, selWidth, textHeight)
				DrawString(textX, textY, "LEFT", textHeight, self.font, sel)
				SetDrawColor(r,g,b,a)

Making this change to lines 349-354 in EditControl seems to work.

@Nostyxx
Copy link
Author

Nostyxx commented Feb 21, 2026

@Blitz54 Much appreciated for the help! Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Search to Notes tab

2 participants