Add support for Expand#1818
Open
Peechey wants to merge 2 commits intoPathOfBuildingCommunity:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adding support for the Seal Support: Expand by updating CalcOffense's calcAoE function with seal logic. In order to differentiate the Seal logic for AoE vs Damage from something like Unleash, I've added a flag to Seal skills to keep them separated. Expand has the flag "AreaSeal" and Unleash has "DamageSeal". PR #1811 would need the same DamageSeal added to Zarokh's Revolt and I will update that if we go forward with this.
I'm also updating the source name for the damage/aoe mods from seals to be dynamic instead of the hardcoded "Unleash" and what would be a hardcoded "Expand." Zarokh's Revolt from 1811 needs this change anyways to be more accurate and GGG could introduce a Revolt version of Expand in the future e.g.
I couldn't test 100% in game as it doesn't have the new radius in the tooltip, but my assumption is Expand gives 90% inc AoE at max seals.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: