Add support for Twisted Empyrean unique mods#1823
Open
Peechey wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Open
Add support for Twisted Empyrean unique mods#1823Peechey wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Peechey wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds parsing for "Attacks with this Weapon have Added Cold Damage equal to 6% to 10% of Maximum Mana" and "Convert 100% of Fire Damage of Mace Skills to Cold Damage". I've made the parser relatively dynamic so this should be able to catch similar mods in the future.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
After screenshot:
1000 total mana

doesn't break fire damage from other skills
