Skip to content

Add build comparison tab#1830

Merged
LocalIdentity merged 19 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-port
May 18, 2026
Merged

Add build comparison tab#1830
LocalIdentity merged 19 commits into
PathOfBuildingCommunity:devfrom
vaisest:comparison-port

Conversation

@vaisest
Copy link
Copy Markdown
Contributor

@vaisest vaisest commented May 11, 2026

Changes from PathOfBuildingCommunity/PathOfBuilding#9543

Description of the problem being solved:

Ports changes, but also improves the trader functionality a lot. Previously (and this is true for PoB1 too) any mod with separate global and local trade filters would fail to match correctly, which meant searching most armour or weapons was not working well. Inverted mods, which say increased on the item, but are reduced with the value negated on the trade site, were also not supported.

These are both now supported. I have tested quite a few items, but given how there are a gazillion stats, it's possible some of them don't function. There are for example some things like the 4 desecration jewel which lack the correct base tags. Megalomaniac is also not supported, because the trade hash format is weird.

Steps taken to verify a working solution:

Tested combinations of the following builds:

The stats have not been verified super accurately, but they seem correct, and nothing has crashed.

Seems most of it is directly compatible with pob2, but various things are hidden behind different variables. These fixes mostly focus on fixing those mistakes. Skill sets were also added to the calcs tab.

Trade hash generation was also reworked. This probably means the trader tool will not generate QueryMods.lua correctly. I don't think anything else uses the tradehash field, though. The rework should correct A LOT of trade hashes. Many stats were being incorrectly concatenated, and most mods with multiple stats were wrong as concatenation is only correct for # to # mods which have a separate minimum and maximum stat

@vaisest vaisest marked this pull request as ready for review May 12, 2026 19:09
@vaisest vaisest force-pushed the comparison-port branch from d49a439 to 75a96c2 Compare May 13, 2026 15:14
@vaisest vaisest marked this pull request as ready for review May 14, 2026 17:23
@vaisest
Copy link
Copy Markdown
Contributor Author

vaisest commented May 14, 2026

image

Increased passive skill effect now applies to tooltips (and this also fixes a crash), but it doesn't seem to be working for the power report lines. Not sure why.

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label May 17, 2026
@LocalIdentity LocalIdentity changed the title [pob1-port] Add build comparison tab Add build comparison tab May 18, 2026
@LocalIdentity LocalIdentity merged commit 8f71bf5 into PathOfBuildingCommunity:dev May 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants