Mastery Mod (Not Supported) losing relationship to mod, when assigning masteries#9893
Open
soratidus999 wants to merge 1 commit into
Open
Mastery Mod (Not Supported) losing relationship to mod, when assigning masteries#9893soratidus999 wants to merge 1 commit into
soratidus999 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes an indexing/association bug in PassiveTreeViewClass:AddNodeTooltip where the “(Not Supported in PoB Yet)” styling/tooltip could attach to the wrong mastery mod when some mastery options are filtered out due to already being selected elsewhere.
Changes:
- Iterates through all mastery effect stat lines to keep a consistent global
lineCountindex, even when an effect is already selected and not displayed. - Only renders tooltip lines for non-selected mastery effects while preserving the underlying index progression used by
node.mods[...].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Author
|
apologies for the copilot spam, that now turned off... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No reported Issues Fixed
Description of the problem being solved:
When assigning masteries, the (Not Supported in PoB Yet) text loses its relationship with the underlying mod its tooltipping, if Mod 3 and Mod 4 are unsupported but mod 1 is already assigned a mastery. it simply shifts the index down
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Demo tree only https://pobb.in/Y3K_UFscbIzl
Before screenshot:
After screenshot:
/First MR to the project