Skip to content

[pob2-port] Fix crash when importing items with +1 suffix rune #9894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
github-actions wants to merge 1 commit into
base: dev
Choose a base branch
from
+17 −1
Open

[pob2-port] Fix crash when importing items with +1 suffix rune #9894

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Classes/ItemsTab.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,7 +695,7 @@ holding Shift will put it in the second.]])
end
return h
end})
for i = 1, 6 do
for i = 1, maxModCount do
local prev = self.controls["displayItemAffix"..(i-1)] or self.controls.displayItemSectionAffix
local drop, slider
local function verifyRange(range, index, drop) -- flips range if it will form discontinuous values
Expand Down
16 changes: 16 additions & 0 deletions src/Classes/ItemsTab.lua.rej
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
diff a/src/Classes/ItemsTab.lua b/src/Classes/ItemsTab.lua (rejected hunks)
@@ -702,12 +702,13 @@ holding Shift will put it in the second.]])
end

-- Section: Affix Selection
+ local maxModCount = 9
self.controls.displayItemSectionAffix = new("Control", {"TOPLEFT",self.controls.displayItemSectionRune,"BOTTOMLEFT"}, {0, 0, 0, function()
if not self.displayItem or not self.displayItem.crafted then
return 0
end
local h = 6
- for i = 1, 6 do
+ for i = 1, maxModCount do
if self.controls["displayItemAffix"..i]:IsShown() then
h = h + 24
if self.controls["displayItemAffixRange"..i]:IsShown() then