Update to Angular 21 - #889
Conversation
c38e7ed to
68d6bcc
Compare
|
We should definitely give this a full smoke test once the code-level review is finished. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 895-package-bootstrap #889 +/- ##
=========================================================
- Coverage 47.85% 47.70% -0.16%
=========================================================
Files 351 351
Lines 11306 11311 +5
Branches 1892 1893 +1
=========================================================
- Hits 5411 5396 -15
- Misses 5705 5724 +19
- Partials 190 191 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
I tried to run this locally and it didn't work for me. I got errors on both npm i and build web-app.
Could you please provide some step-by-step for making it work locally? Maybe I am doing smth wrong?
Also, in the code, there are still some *ngIfs present in src/stories/header.component.ts. Wouldn't this break when running the storybook? I can check it once I can make the branch work on my local.
68d6bcc to
7dcceda
Compare
|
@aasandei-vsp I've rebased this on the bootstrap branch; could you try again? For me, from devenv, I run:
Regarding |
1c61e3b to
3e68ab8
Compare
64fb465 to
ae51380
Compare
aasandei-vsp
left a comment
There was a problem hiding this comment.
After some struggle with my own environment, I managed to test this. Sorry for the delay.
LGTM
6b45b52 to
28b87cd
Compare
This upgrade comes with a lot of package bumps, as expected. For the short term we have to override ng-mocks' peer dependencies. There is an open PR to add formal angular support. If tests pass, this is OK for now. We also need to use a release candidate for angular firebase. This is not ideal, but similarly if it works that's OK. It should be noted that angular firebase is not maintained at the cadence we would prefer and so this is another reason it's good we're moving away from it. Issue #869 Upgrade to Angular 21
28b87cd to
1a2cca9
Compare
|
Merging this into the bootstrap upgrade |
This PR updates Angular to v21 (the current major release). It also bumps related dependencies to versions that also support Angular 21.
This is now based on the branch reflected in #896 -- we should smoke test this to cover both changes, but this should be merged second.
Resolves #869