Skip to content

Update to Angular 21 - #889

Merged
slifty merged 1 commit into
895-package-bootstrapfrom
869-update-angular-21
Feb 3, 2026
Merged

Update to Angular 21#889
slifty merged 1 commit into
895-package-bootstrapfrom
869-update-angular-21

Conversation

@slifty

@slifty slifty commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

This PR updates Angular to v21 (the current major release). It also bumps related dependencies to versions that also support Angular 21.

This is now based on the branch reflected in #896 -- we should smoke test this to cover both changes, but this should be merged second.

Resolves #869

@slifty
slifty force-pushed the 869-update-angular-21 branch 3 times, most recently from c38e7ed to 68d6bcc Compare January 15, 2026 19:45
@slifty
slifty requested a review from aasandei-vsp January 15, 2026 19:45
@slifty

slifty commented Jan 15, 2026

Copy link
Copy Markdown
Contributor Author

We should definitely give this a full smoke test once the code-level review is finished.

@codecov

codecov Bot commented Jan 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 47.70%. Comparing base (ae51380) to head (28b87cd).

Files with missing lines Patch % Lines
...rowser/components/file-list/file-list.component.ts 0.00% 1 Missing ⚠️
...rc/app/shared/directives/bg-image-src.directive.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           895-package-bootstrap     #889      +/-   ##
=========================================================
- Coverage                  47.85%   47.70%   -0.16%     
=========================================================
  Files                        351      351              
  Lines                      11306    11311       +5     
  Branches                    1892     1893       +1     
=========================================================
- Hits                        5411     5396      -15     
- Misses                      5705     5724      +19     
- Partials                     190      191       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aasandei-vsp aasandei-vsp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to run this locally and it didn't work for me. I got errors on both npm i and build web-app.
Could you please provide some step-by-step for making it work locally? Maybe I am doing smth wrong?

Also, in the code, there are still some *ngIfs present in src/stories/header.component.ts. Wouldn't this break when running the storybook? I can check it once I can make the branch work on my local.

@slifty
slifty force-pushed the 869-update-angular-21 branch from 68d6bcc to 7dcceda Compare January 27, 2026 19:17
@slifty
slifty changed the base branch from main to 895-package-bootstrap January 27, 2026 19:17
@slifty

slifty commented Jan 27, 2026

Copy link
Copy Markdown
Contributor Author

@aasandei-vsp I've rebased this on the bootstrap branch; could you try again?

For me, from devenv, I run:

docker compose build web-app and then docker compose up -d


Regarding *ngIf I believe it works, just is deprecated. That said good catch and I'll update that to the modern syntax now.

@slifty
slifty requested a review from aasandei-vsp January 27, 2026 19:33
@slifty
slifty force-pushed the 869-update-angular-21 branch 7 times, most recently from 1c61e3b to 3e68ab8 Compare January 28, 2026 19:50
@slifty
slifty force-pushed the 895-package-bootstrap branch from 64fb465 to ae51380 Compare January 28, 2026 19:51

@aasandei-vsp aasandei-vsp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After some struggle with my own environment, I managed to test this. Sorry for the delay.

LGTM

@slifty
slifty force-pushed the 869-update-angular-21 branch 3 times, most recently from 6b45b52 to 28b87cd Compare January 30, 2026 13:32
This upgrade comes with a lot of package bumps, as expected.

For the short term we have to override ng-mocks' peer dependencies.
There is an open PR to add formal angular support.  If tests pass, this
is OK for now.

We also need to use a release candidate for angular firebase.  This is
not ideal, but similarly if it works that's OK.  It should be noted that
angular firebase is not maintained at the cadence we would prefer and so
this is another reason it's good we're moving away from it.

Issue #869 Upgrade to Angular 21
@slifty
slifty force-pushed the 869-update-angular-21 branch from 28b87cd to 1a2cca9 Compare February 2, 2026 22:37
@slifty

slifty commented Feb 3, 2026

Copy link
Copy Markdown
Contributor Author

Merging this into the bootstrap upgrade

@slifty
slifty merged commit 73876d9 into 895-package-bootstrap Feb 3, 2026
7 of 14 checks passed
@slifty
slifty deleted the 869-update-angular-21 branch February 3, 2026 03:06
@slifty
slifty restored the 869-update-angular-21 branch February 3, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade to Angular 21

2 participants