Skip to content

[Retry] Allow infantry to perform type conversion when deploying and undeploying#2250

Merged
TaranDahl merged 8 commits into
Phobos-developers:developfrom
DeathFishAtEase:Retry_Convert.(Un)deploy
Jun 21, 2026
Merged

[Retry] Allow infantry to perform type conversion when deploying and undeploying#2250
TaranDahl merged 8 commits into
Phobos-developers:developfrom
DeathFishAtEase:Retry_Convert.(Un)deploy

Conversation

@DeathFishAtEase

Copy link
Copy Markdown
Collaborator

Reimplement #2239.

  • Used a more performant method
  • The execution timing of convert was changed from the start of Sequence to after its end
Retry  Convert (Un)deploy

E1↔GGI, YURI↔YURIPR, E2↔BORIS

@DeathFishAtEase DeathFishAtEase self-assigned this Jun 11, 2026
@DeathFishAtEase DeathFishAtEase added Tested ⚙️T1 T1 maintainer review is sufficient labels Jun 11, 2026
@github-actions

github-actions Bot commented Jun 11, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@phoboscn-bot

Copy link
Copy Markdown

To Chinese users:
This pull request has been mentioned on Phobos CN. There might be relevant details there:

致中文用户:
此拉取请求已在 Phobos CN 上被提及。那里可能有相关详细信息:

https://www.phoboscn.top/t/topic/545/1

@Coronia Coronia requested a review from Starkku June 11, 2026 15:39
@Coronia

Coronia commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

The performance cost is now resolved
image

@TaranDahl TaranDahl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Starkku Going to merge this in 24h if you have no further instructions.

@TaranDahl TaranDahl added the Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions. label Jun 20, 2026

@Starkku Starkku left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.

@TaranDahl TaranDahl merged commit b81a1dd into Phobos-developers:develop Jun 21, 2026
7 checks passed
@DeathFishAtEase DeathFishAtEase deleted the Retry_Convert.(Un)deploy branch June 21, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️T1 T1 maintainer review is sufficient Tested Will be merged in 24h This PR will be merged in 24 hours if no one has further instructions.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants