Lower AprilTagDetector's maxLineFitMSE#2138
Open
Gold856 wants to merge 3 commits intoPhotonVision:mainfrom
Open
Lower AprilTagDetector's maxLineFitMSE#2138Gold856 wants to merge 3 commits intoPhotonVision:mainfrom
Gold856 wants to merge 3 commits intoPhotonVision:mainfrom
Conversation
github-actions
Bot
added
the
backend
Member
spacey-sooty
left a comment
spacey-sooty
left a comment
There was a problem hiding this comment.
The comment above is no longer true please change
Contributor
Author
|
Which comment? I edited the description to be slightly more specific just in case, but still unsure. |
Member
The WPILib 2025 defaults comment a few lines above your change. I can't leave a comment on it since you haven't modified it |
Gold856
force-pushed
the
set-max-line-fit-mse
branch
from
891ba03 to
6572411
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1817. Based on AprilRobotics/apriltag#375 (comment), I lowered it and light testing seems to indicate that this doesn't really impact range, but it does prevent cutoff tags from being detected. This value could be tuned lower to reduce bad detections even more, or higher to reduce false negatives, but this seems to be a good starting point.
Meta
Merge checklist: