Skip to content

Add a toggle in getFitnessScore to respect user-provided indices in Registration#6441

Merged
mvieth merged 1 commit into
PointCloudLibrary:masterfrom
AlrIsmail:fix-registration-fitness-score-indices
Jun 3, 2026
Merged

Add a toggle in getFitnessScore to respect user-provided indices in Registration#6441
mvieth merged 1 commit into
PointCloudLibrary:masterfrom
AlrIsmail:fix-registration-fitness-score-indices

Conversation

@AlrIsmail
Copy link
Copy Markdown
Contributor

This PR resolves #6437 where Registration::getFitnessScore() completely ignored the indices_ member set via setIndices(). Previously, it evaluated the fitness score across the entire source cloud without a direct way to limit it.

Changes:

  • Added an optional use_indices = false parameter to pcl::Registration::getFitnessScore.
  • Updated the getFitnessScore implementation in impl/registration.hpp so that when use_indices = true and indices_ are present
  • Added TEST(PCL, Registration_getFitnessScore_Indices) in test_registration.cpp

@AlrIsmail AlrIsmail force-pushed the fix-registration-fitness-score-indices branch from e2a2750 to f699bd9 Compare May 11, 2026 19:38
@mvieth
Copy link
Copy Markdown
Member

mvieth commented May 23, 2026

Please fix the formatting by running clang-format (e.g. make format if you are on Linux)

@AlrIsmail AlrIsmail force-pushed the fix-registration-fitness-score-indices branch from f699bd9 to edbadeb Compare May 23, 2026 16:12
Copy link
Copy Markdown
Member

@mvieth mvieth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvieth mvieth added changelog: enhancement Meta-information for changelog generation module: registration labels Jun 3, 2026
@mvieth mvieth merged commit 4c3b36e into PointCloudLibrary:master Jun 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: enhancement Meta-information for changelog generation module: registration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[registration] getFitnessScore() does not respect setIndices in pcl::Registration

3 participants