Revert "fix(agent): close proxy ingest upload per batch so events"#3044
Closed
charlesvien wants to merge 2 commits into
Closed
Revert "fix(agent): close proxy ingest upload per batch so events"#3044charlesvien wants to merge 2 commits into
charlesvien wants to merge 2 commits into
Conversation
This reverts commit b38b7f6.
charlesvien
added
the
Stamphog
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
![stamphog[bot]](https://avatars.githubusercontent.com/in/3000332?s=60&v=4){kind=small}
There was a problem hiding this comment.
This reverts a deliberate fix for proxy-path event delivery — the original code closed the ingest stream per batch specifically because a buffering ingress strands events on long-lived uploads. Reverting silently reintroduces that potential event loss, and there are zero reviews to confirm the proxy behavior has changed or that the revert is safe. Human review is required before merging.
stamphog
Bot
removed
the
Stamphog
Contributor
|
Reviews (1): Last reviewed commit: "Revert "fix(agent): Flush proxy ingest u..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert changes to proxy ingest upload buffering