feat(data-warehouse): add Jira as a self-driving inbox source#3306
Open
Gilbert09 wants to merge 3 commits into
Open
feat(data-warehouse): add Jira as a self-driving inbox source#3306Gilbert09 wants to merge 3 commits into
Gilbert09 wants to merge 3 commits into
Conversation
Wire Jira into the Self-driving Inbox source toggles (source_product "jira", issues table) alongside GitHub/Linear/Zendesk/pganalyze. Instead of hardcoding another per-source credential form, add a generic DynamicSourceSetup that renders the connect form from the warehouse wizard endpoint (external_data_sources/wizard/?source_type=Jira), so field names/labels/required/secret come from the backend and never drift. Jira routes through it; GitHub (repo picker) and Linear (OAuth) keep their bespoke flows. Also add the adding-inbox-sources skill documenting the end-to-end (two-repo) pattern for adding further sources. Note: requires the matching posthog/posthog signals-scout support (source_product choice + Jira issues emitter) to land first, or the toggle will 400 on enable.
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
|
Reviews (1): Last reviewed commit: "feat(data-warehouse): add Jira as a self..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
React Doctor found 3 issues in 2 files · 3 warnings. 3 warnings
Reviewed by React Doctor for commit |
- Render `textarea` fields with a real multi-line `TextArea` instead of a single-line `TextField.Root` typed as text. - Gate the submit button on required `select` fields with no value (and no defaultValue), not just required text inputs. - Show a visible label above text-like inputs, matching the select branch. - Remove the unreachable `createJiraDataSource` / `JiraDataSourceParams` dead code now that Jira setup goes through the generic form. Generated-By: PostHog Code Task-Id: be97b984-e201-438d-94c8-b6fdbe0fc702
Generated-By: PostHog Code Task-Id: be97b984-e201-438d-94c8-b6fdbe0fc702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The self-driving inbox lets users connect issue/ticket sources (GitHub, Linear, Zendesk) so the scout can surface findings. Jira — a very common issue tracker — isn't available. Separately, each source's connect form was hand-coded, which drifts from the backend's actual field requirements.
Changes
source_product: "jira",issuestable) across@posthog/shared,@posthog/api-client,@posthog/core, and@posthog/ui.DynamicSourceSetupthat renders the connect form from the warehouse wizard endpoint (external_data_sources/wizard/?source_type=Jira) instead of hardcoding fields — field names/labels/required/secret come from the backend and can't drift. Jira uses it; GitHub (repo picker) and Linear (OAuth) keep their bespoke flows.ZendeskSetup/PgAnalyzeSetupcan migrate to it opportunistically.Depends on PostHog/posthog#69680 (Jira signals-scout support), which must land first: the inbox toggle creates a
SignalSourceConfigwithsource_product: "jira", which the backend rejects until that ships.How did you test this?
pnpm --filter @posthog/ui --filter @posthog/core typecheck— clean for the changed files.vitest runonsignalSourceService+reportMembership— pass.Automatic notifications