feat(harness): brand hog with a hedgehog glyph instead of pi's π#3316
Draft
adboio wants to merge 1 commit into
Draft
feat(harness): brand hog with a hedgehog glyph instead of pi's π#3316adboio wants to merge 1 commit into
adboio wants to merge 1 commit into
Conversation
The hog-branding extension already replaced pi's default `π` title prefix with a plain "hog", but nothing carried PostHog's mascot through. Front both the TUI header line and the OS terminal title with the 🦔 hedgehog glyph so the harness reads as posthoggy rather than pi's bare symbol. Generated-By: PostHog Code Task-Id: 5d9d5188-0670-497f-b42f-caca6ae34df5
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
React Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
hogharness is built on pi, and pi's default terminal title/header uses aπglyph. Thehog-brandingextension already strips that prefix down to a plainhog, but nothing carries PostHog's hedgehog mascot through — so the branding reads as pi's leftover symbol rather than as PostHog.Why: Requested to make the harness header feel fun and on-brand — a hedgehog instead of the pi symbol.
Changes
BRAND_GLYPH(🦔) constant to thehog-brandingextension and front both the TUI header line and the OS terminal title with it, so they render as🦔 hog …in place of pi'sπ.Header line:
🦔 hog (A Pi distribution by PostHog) v<version>Terminal title:
🦔 hog - <session> - <cwd>How did you test this?
pnpm --filter @posthog/harness exec vitest run— full harness suite passes (472 tests), including the updatedhog-brandingheader/title assertions.pnpm --filter @posthog/harness typecheck— clean.biome lint packages/harness/src/extensions/hog-branding/— clean.Automatic notifications
Created with PostHog Code