Fix sorting order in aspect score for Companion, ComparERSub#684
Merged
lthoang merged 1 commit intoPreferredAI:masterfrom Mar 29, 2026
Merged
Conversation
lthoang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix: top-aspect selection in Companion and ComparER ranking
Both models used
argsort(axis=1)[::-1]to select top aspects for the ranking score, intending to sort aspects descending. However,[::-1]on a 2D array reverses rows (items), not columns (aspects). The result was that each item received aspect indices from a different item's ascending sort — selecting the wrong item's worst aspects instead of its own best aspects.Fix: change
[::-1]to[:, ::-1]in recom_companion.pyx and recom_comparer_sub.pyx.Related Issues
N/A
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).