fix mismatch in opinion handling#685
Merged
lthoang merged 1 commit intoPreferredAI:masterfrom Mar 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change fixes two mismatch in the Companion model’s user–item–aspect–negative opinion (UIAON) in
recom_companion.pyx.Score lookup for the negative-opinion pair
When the sampled negative opinion
o_jdxis present inuser_item_aspect_neg_opinion_dict, the code comparesi_scoretoj_scorefrom the same (u,i,a,o) key. Thatj_scoreread fromuser_item_aspect_pos_opinion_dict, which is inconsistent. It now reads fromuser_item_aspect_neg_opinion_dict, so it are based on the correct dict now.Gradients
The UIAON prediction uses
G3(anddel_g3was already updated withG3), but the user-factor loop was backpropagatingdel_u/del_a/del_owithG2. Those terms now useG3, so gradients align with the tensors used.Related Issues
N/A
Checklist:
README.md(if you are adding a new model).examples/README.md(if you are adding a new example).datasets/README.md(if you are adding a new dataset).