deprecate Bound|Py::(try_)borrow(_mut) (Part 2)#6121
Draft
Icxolu wants to merge 2 commits into
Draft
Conversation
Icxolu
force-pushed
the
deprecate/borrow
branch
3 times, most recently
from
7e16282 to
09a3996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 2 of #6120
Deprecates
(try_)borrow(_mut)family of methods onBoundandPy, and introducingtry_borrow_guardandtry_borrow_guard_mutas successors (to be renamed back at some later release). I intentionally did not reintroduce panicking variants. I think the error condition got more likely now with free-threading and we should encourage users to handle such errors gracefully.Only the second commit is relevant, first commit is #6120. I'll rebase once #6120 lands.
See also #6083