removing pathConditionRoot from the states #98
Merged
+17
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsvgit
requested changes
Dec 20, 2025
Member
gsvgit
left a comment
gsvgit
left a comment
There was a problem hiding this comment.
Fix edges addition between state and PathCondition.
VSharp.Explorer/AISearcher.fs
Outdated
|
|
||
| index_pcToState.[firstFreePositionInPcToState] <- | ||
| int64 pathConditionVerticesIds[state.PathCondition.Id] | ||
| int64 pathConditionVerticesIds[state.PathCondition.[firstFreePositionInPcToState]] |
Member
There was a problem hiding this comment.
Looks strange. You should add edges between state and all vertices in state.PathCondition.
Anya497
reviewed
Dec 20, 2025
VSharp.ML.GameServer/Messages.fs
Outdated
| | StandardFunctionApplication = 45 | ||
| | Cast = 46 | ||
| | Combine = 47 | ||
| | PathConditionRoot = 48 |
Collaborator
There was a problem hiding this comment.
This line can be removed too.
gsvgit
requested changes
Dec 24, 2025
VSharp.IL/Serializer.fs
Outdated
| ) | ||
|
|
||
| pathConditionDelta.Add pathConditionRoot | ||
| let pathConditionId = [| for p in pathCondition -> termsWithId.[p] |] |
Member
There was a problem hiding this comment.
Why "id"? Why not just pathCondition?
VSharp.Explorer/AISearcher.fs
Outdated
| |> Array.iteri (fun i pcId -> | ||
| let j = firstFreePositionInPcToState + i | ||
| index_pcToState[j] <- int64 pathConditionVerticesIds[pcId] | ||
| index_pcToState[numOfParentOfEdges + j] <- int64 stateIds[state.Id]) |
Member
There was a problem hiding this comment.
Why so strange position in index_pcToState to write?
gsvgit
reviewed
Dec 26, 2025
VSharp.Explorer/AISearcher.fs
Outdated
| let shapeOfPcToState = [| 2L; gameState.States.Length |] | ||
| let index_pcToState = Array.zeroCreate (2 * gameState.States.Length) | ||
|
|
||
| let pathConditionNum = |
Member
There was a problem hiding this comment.
It would be better to move pathConditionNum calculation closer to this line to prevent redundant iterations over states. Look at the numOfParentOfEdges calculation.
gsvgit
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed pathConditionRoot from the states