feat(QOV-1953): add --read-only flag to cluster kubeconfig and get-token#653
Open
Guimove wants to merge 2 commits into
Open
feat(QOV-1953): add --read-only flag to cluster kubeconfig and get-token#653Guimove wants to merge 2 commits into
Guimove wants to merge 2 commits into
Conversation
- cluster kubeconfig --read-only: downloads a kubeconfig with read-only exec plugin (calls get-token --read-only), output file named kubeconfig-readonly-<id>.yaml - cluster get-token --read-only: requests a SA-backed read-only token instead of an admin cloud-provider token - All existing callers pass readOnly=false explicitly — no behavior change CLI will compile once qovery-client-go is regenerated from the spec (ReadOnly() method on ApiGetClusterKubeconfigRequest and ApiGetClusterTokenByClusterIdRequest).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
QOV-1953
Adds --read-only (-r) flag to:
How it works:
No behavior change on existing commands, all callers pass readOnly=false explicitly.
Dependency: requires qovery-client-go to be regenerated after qovery-openapi-spec PR #1107 is merged. After the client is published, run go get github.com/qovery/qovery-client-go@latest && go mod tidy.
Merge order
https://qovery.atlassian.net/browse/QOV-1953