Restore the LogEntry based SaveLogs signature - #9658
Merged
jhonabreul merged 1 commit intoAug 7, 2026
Conversation
jhonabreul
marked this pull request as ready for review
August 6, 2026 23:12
Martin-Molinero
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR #9632 split
BaseResultsHandler.SaveLogsinto two overloads (List<LogEntry>andIEnumerable<string>) soBacktestingResultHandler.Exit()could reuse the message-list clone. This restores the original public API:BaseResultsHandler.SaveLogs(string id, List<LogEntry> logs)is again the single overload, writing the entry messages itself.BacktestingResultHandler.Exit()clones theLogEntrylist under the log store lock and passes it toSaveLogs, as it did before Run a reduced results analysis periodically during backtests #9632.CloneLogs()stays for the final-result and in-run analysis paths, which need the message strings.Related Issue
N/A
Motivation and Context
SaveLogsis a public virtual member that result handler implementations override; its signature should not have changed as a side effect of #9632.Requires Documentation Change
N/A
How Has This Been Tested?
BaseResultsHandlerTests,BacktestingResultHandlerTestsandLiveTradingResultHandlerTests: 31 passed.BacktestingResultHandler.Exit()saved the complete log file (launch line, 390 bar lines, end-of-algorithm line, completion line) at the end of the backtest.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>