[mix_model]: Fix issues and improve the lecture by bishmaybarik · Pull Request #642 · QuantEcon/lecture-python.myst

bishmaybarik · 2025-10-01T09:22:00Z

This PR fixes the following issues:

Fixes [mix_model] FIX: links are full web links across the lecture #577

The issue was the following:

style guide review
fix full web links that are currently used across the lectures with a range of link text, doc links.

github-actions · 2025-10-01T09:37:26Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (fb4ddb0)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-10-01T10:10:31Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (7cba5eb)

📚 Changed Lecture Pages: mix_model

bishmaybarik · 2025-10-01T10:46:56Z

hi @mmcky , I have made some changes and made sure I pushed everything to this branch. although I have checked it myself, it'll be nice to have it reviewed by you :-)

if there are further issues with the lecture, please let me know!

github-actions · 2025-10-01T10:57:23Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (67c3a4b)

📚 Changed Lecture Pages: mix_model

Copilot

Pull Request Overview

This PR fixes formatting, style, and link issues in the mix_model lecture to align with style guidelines and improve readability. The changes primarily involve converting raw URLs to proper markdown links, fixing capitalization in headings, and correcting a few punctuation errors.

Key Changes

Converted raw web links to proper markdown format with descriptive text
Fixed capitalization in section headings to follow consistent style
Made minor punctuation and text corrections

bishmaybarik · 2025-10-13T02:28:25Z

hi @mmcky, may I know if you have any thoughts on this? I would humbly request you to review this whenever you have the time :-)

HumphreyYang

Many thanks @bishmaybarik! These are great changes!

Noted that if we use

{doc}`lecture_name`

It will give use a hyperlink with the lecture title. So we can reduce the usage of "this lecture" in the lectures.

There are also a few lines of code that's touching 80-character limit so please have a go at breaking them into two lines!

Please let me know what you think.

bishmaybarik · 2025-10-25T15:43:22Z

Thanks for all the suggestions @HumphreyYang -- all of the suggestions are helpful!

I'll make the necessary changes and update this PR as soon as possible.

github-actions · 2025-11-07T06:01:34Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (77881b7)

📚 Changed Lecture Pages: mix_model

bishmaybarik · 2025-11-07T06:04:31Z

thanks again for these great suggestions @HumphreyYang. All the changes have been made -- it would be great if you could have a look at it whenever you have time :-)

github-actions · 2025-11-07T06:06:06Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (5b63456)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:07:23Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (76c9249)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:11:51Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (aabecbc)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:16:12Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (cc3bc96)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:17:08Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (11f108d)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:18:16Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (92cd96e)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:20:03Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (4b926c0)

📚 Changed Lecture Pages: mix_model

github-actions · 2025-11-07T06:20:09Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (d7ed9ce)

📚 Changed Lecture Pages: mix_model

jstac · 2026-07-08T06:03:34Z

🤖 Status note for a future session — from a maintainer investigation on 2026-07-08 into why open-PR previews 404. Context only, not instructions.

Netlify preview: https://pr-642--sunny-cactus-210e3e.netlify.app/ currently returns 404.

Why previews are down (repo-wide findings)

1. This branch is stale — 174 commits behind main. A preview build compiles the whole site from this branch. This branch's lectures/house_auction.md still has unpinned !pip install prettytable, which now breaks on a wcwidth incompatibility. main fixed this on 2026-06-28 by pinning prettytable<3.18 (#939). This alone fails any rebuild of this branch until it's updated to main.

2. The arviz failure was a red herring — do NOT pin arviz or rewrite plotting. A 2026-07-07 rebuild also failed in ar1_bayes/ar1_turningpts with an arviz_plots figsize ValueError. That was a transient bug in an intermediate arviz-plots 1.x release, already fixed in arviz 1.2.0. Verified locally on a clean latest-stack venv: the real az.plot_trace(trace) cell (pymc + numpyro InferenceData) runs green. The lectures use only 1.x-compatible arviz APIs (plot_trace, summary, from_numpyro, compare).

Recommended first step for this PR

Update this branch to main (merge or rebase — pulls in #939 plus ~174 other commits), then let CI rebuild. On today's latest libraries the site builds clean, so the preview should return. house_auction is the known blocker; updating also picks up other since-merged fixes — rebuild and address any remaining per-lecture failures. Verify with:

curl -sI https://pr-642--sunny-cactus-210e3e.netlify.app/mix_model.html

This PR touches: mix_model.md. Last CI build: success@2025-11-07. Branch: 174 commits behind main as of 2026-07-08.

Rebased onto main. Fixes #577: converts bare/awkward links to MyST {doc} and inline-link form, applies sentence-case section headings, and cleans up prose/whitespace. Preserves the rng changes from #978.

Rebased onto main on top of the style-guide branch (#642). Converts the Numba/NumPy simulation code to JAX (jax.random keys, jax.lax.scan, jax.vmap), replacing the interim np.random Generator migration from #978. Keeps #642's link/heading/prose fixes. Verified: lecture runs end-to-end (JAX cells + numpyro MCMC) on CPU.

github-actions · 2026-07-19T01:17:08Z

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app

Commit: 2d31ac8

📚 Changed Lectures

mix_model

Build Info

Workflow: Build Project [using jupyter-book]

jstac · 2026-07-19T01:38:48Z

Many thanks for putting this in @bishmaybarik , it took a long time to get to it but we're merging now!

Rebased onto main (now containing the #642 style pass). Converts the Numba/NumPy simulation code to JAX (jax.random keys, jax.lax.scan, jax.vmap), superseding the interim np.random Generator migration (#978). draw_lottery_MC now uses jax.scipy.stats.beta.cdf and a jax.random key instead of scipy.stats + np.random, so the lecture no longer touches NumPy's legacy RNG at all. Verified: full lecture (JAX cells + numpyro NUTS MCMC) runs end-to-end on CPU; MC draws match the target mixture density. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Rebased onto main (post #642 style pass). Converts the Numba/NumPy simulation code to JAX (jax.random keys, jax.lax.scan, jax.vmap), superseding the interim np.random Generator migration (#978). Randomness uses explicit jax.random.key threading (keys passed into simulate / draw_lottery / draw_lottery_MC / simulate_mixed / plot_π_seq / π_lim, split where needed) rather than deriving seeds from parameter values, matching the JAX conversion style guide. draw_lottery_MC uses jax.scipy.stats.beta.cdf, so the lecture no longer touches NumPy's legacy RNG. Single seed 42 throughout. Verified: full lecture (JAX cells + numpyro NUTS MCMC) runs end-to-end on CPU; MC draws match the target mixture density. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* [mix_model] Convert code to JAX Rebased onto main (post #642 style pass). Converts the Numba/NumPy simulation code to JAX (jax.random keys, jax.lax.scan, jax.vmap), superseding the interim np.random Generator migration (#978). Randomness uses explicit jax.random.key threading (keys passed into simulate / draw_lottery / draw_lottery_MC / simulate_mixed / plot_π_seq / π_lim, split where needed) rather than deriving seeds from parameter values, matching the JAX conversion style guide. draw_lottery_MC uses jax.scipy.stats.beta.cdf, so the lecture no longer touches NumPy's legacy RNG. Single seed 42 throughout. Verified: full lecture (JAX cells + numpyro NUTS MCMC) runs end-to-end on CPU; MC draws match the target mixture density. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * [mix_model] Style-guide compliance pass Bring the lecture into full style-guide compliance: - figures: remove matplotlib titles (ax.set_title), drop hard-coded figsize, use lw=2 on all line charts, lower-case axis labels - math: \mathbb{E} / \mathbb{P} for expectation/probability, \mathrm{Beta} for the distribution name, \log instead of log - writing: IID (not i.i.d.), Bayes' law (not Bayes' Law / Bayes law) - doclinks: same-series links use the [](name) auto-title form and drop the generic 'this quantecon lecture' text - code: don't pip install jax at the top (GPU admonition covers it), remove the unused pandas import Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: John Stachurski <john.stachurski@gmail.com>

bishmaybarik self-assigned this Oct 1, 2025

bishmaybarik added in-work improve labels Oct 1, 2025

bishmaybarik marked this pull request as ready for review October 1, 2025 10:44

bishmaybarik requested a review from mmcky October 1, 2025 10:44

bishmaybarik added ready and removed in-work labels Oct 1, 2025

bishmaybarik changed the title ~~[FIX]: Improve the mix_model.md lecture~~ [mix_model.md]: Fix issues and improve the lecture Oct 1, 2025

bishmaybarik changed the title ~~[mix_model.md]: Fix issues and improve the lecture~~ [mix_model]: Fix issues and improve the lecture Oct 1, 2025

bishmaybarik requested a review from Copilot October 6, 2025 08:36

Copilot AI reviewed Oct 6, 2025

View reviewed changes

HumphreyYang reviewed Oct 21, 2025

View reviewed changes

HumphreyYang added review and removed ready labels Oct 21, 2025

bishmaybarik requested a review from HumphreyYang November 7, 2025 06:04

[mix_model] Style-guide review: links, headings, prose

2d31ac8

Rebased onto main. Fixes #577: converts bare/awkward links to MyST {doc} and inline-link form, applies sentence-case section headings, and cleans up prose/whitespace. Preserves the rng changes from #978.

jstac force-pushed the mixmodel-fixes branch from 4b926c0 to 2d31ac8 Compare July 19, 2026 00:57

jstac merged commit 2632849 into main Jul 19, 2026
2 checks passed

jstac deleted the mixmodel-fixes branch July 19, 2026 01:38

Uh oh!

Uh oh!

Conversation

bishmaybarik commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2025

Uh oh!

github-actions Bot commented Oct 1, 2025

Uh oh!

bishmaybarik commented Oct 1, 2025

Uh oh!

github-actions Bot commented Oct 1, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Key Changes

Uh oh!

bishmaybarik commented Oct 13, 2025

Uh oh!

HumphreyYang left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bishmaybarik commented Oct 25, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

bishmaybarik commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

github-actions Bot commented Nov 7, 2025

Uh oh!

jstac commented Jul 8, 2026

Why previews are down (repo-wide findings)

Recommended first step for this PR

Uh oh!

github-actions Bot commented Jul 19, 2026

📖 Netlify Preview Ready!

📚 Changed Lectures

Uh oh!

jstac commented Jul 19, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bishmaybarik commented Oct 1, 2025 •

edited

Loading