[hoist_failure] Clean up the code and correct minor errors - #656
[hoist_failure] Clean up the code and correct minor errors#656HumphreyYang wants to merge 3 commits into
Conversation
|
📖 Netlify Preview Ready! Preview URL: https://pr-656--sunny-cactus-210e3e.netlify.app (a9df52c) 📚 Changed Lecture Pages: hoist_failure |
|
📖 Netlify Preview Ready! Preview URL: https://pr-656--sunny-cactus-210e3e.netlify.app (174da1f) 📚 Changed Lecture Pages: hoist_failure |
|
🤖 Status note for a future session — from a maintainer investigation on 2026-07-08 into why open-PR previews 404. Context only, not instructions. Netlify preview: https://pr-656--sunny-cactus-210e3e.netlify.app/ currently returns 404. Why previews are down (repo-wide findings)1. This branch is stale — 166 commits behind 2. The arviz failure was a red herring — do NOT pin arviz or rewrite plotting. A 2026-07-07 rebuild also failed in Recommended first step for this PRUpdate this branch to This PR touches: |
|
Hi @HumphreyYang, I'm working through the NumPy random API migration in QuantEcon/meta#299, and This PR already rewrites the sampling cell, so rather than open a separate PR that changes the same lines, I thought I would ask here first. While you are in there, would you be happy to use the Generator API for those draws? rng = np.random.default_rng(1234)
s1 = rng.lognormal(μ, σ, n_samples)
s2 = rng.lognormal(μ, σ, n_samples)
s3 = rng.lognormal(μ, σ, n_samples)That keeps the seed you added, and it saves us both from a conflict on the same lines. If you would rather keep this PR as it is, I am happy to do the migration in a separate PR once this one is merged. |
This PR cleans up the code and correct minor errors and typos across the lecture.
It also improves the printing and smooth some of the sentences.