-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: Introduce new summary section for data metrics #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Moritz Potthoff (MoritzPotthoffQC)
wants to merge
31
commits into
main
Choose a base branch
from
data-inspection-section
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,022
−868
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
bff2594
init
MoritzPotthoffQC 51fbda2
add test
MoritzPotthoffQC cb086ef
refactor
MoritzPotthoffQC 526c944
simplify
MoritzPotthoffQC 5732c37
fix
MoritzPotthoffQC 5867021
review
MoritzPotthoffQC 6b705e7
review
MoritzPotthoffQC 6c868d6
review
MoritzPotthoffQC 6802592
review
MoritzPotthoffQC d827967
refactor
MoritzPotthoffQC 2a49d96
simplify
MoritzPotthoffQC eef3d3b
simplify
MoritzPotthoffQC e918bbf
simplify
MoritzPotthoffQC 65d80d6
fix
MoritzPotthoffQC ffeb05a
cleanup
MoritzPotthoffQC c116fdf
improve
MoritzPotthoffQC a57dc0f
docs
MoritzPotthoffQC 1adcf78
review
MoritzPotthoffQC 4000181
fix
MoritzPotthoffQC a52e24c
simplify
MoritzPotthoffQC 2d3f152
fix
MoritzPotthoffQC a0955c0
fix
MoritzPotthoffQC 0d9be70
add test
MoritzPotthoffQC 7ecd908
Potential fix for pull request finding
MoritzPotthoffQC f44fc4f
review
MoritzPotthoffQC 8c7c45a
Potential fix for pull request finding
MoritzPotthoffQC a6bb6d8
review
MoritzPotthoffQC ddc31f8
coverage
MoritzPotthoffQC 69e5893
coverage
MoritzPotthoffQC 42787c7
fix
MoritzPotthoffQC b1ac321
review
MoritzPotthoffQC File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -25,7 +25,8 @@ | |||||||||||||
| lazy_len, | ||||||||||||||
| make_and_validate_mapping, | ||||||||||||||
| ) | ||||||||||||||
| from .metrics import Metric, MetricFn, _make_numeric_metric | ||||||||||||||
| from .metrics.change import ChangeMetric, ChangeMetricFn | ||||||||||||||
| from .metrics.data import DataMetric, DataMetricFn | ||||||||||||||
|
|
||||||||||||||
| if TYPE_CHECKING: # pragma: no cover | ||||||||||||||
| # NOTE: We cannot import at runtime as we're otherwise running into circular | ||||||||||||||
|
|
@@ -920,7 +921,8 @@ def summary( | |||||||||||||
| right_name: str = Side.RIGHT, | ||||||||||||||
| slim: bool = False, | ||||||||||||||
| hidden_columns: list[str] | None = None, | ||||||||||||||
| metrics: Mapping[str, MetricFn | Metric] | None = None, | ||||||||||||||
| data_metrics: Mapping[str, DataMetricFn | DataMetric] | None = None, | ||||||||||||||
| change_metrics: Mapping[str, ChangeMetricFn | ChangeMetric] | None = None, | ||||||||||||||
| ) -> Summary: | ||||||||||||||
| """Generate a summary of all aspects of the comparison. | ||||||||||||||
|
|
||||||||||||||
|
|
@@ -950,18 +952,26 @@ def summary( | |||||||||||||
| advanced users who are familiar with the summary format. | ||||||||||||||
| hidden_columns: Columns for which no values are printed, e.g. because they | ||||||||||||||
| contain sensitive information. | ||||||||||||||
| metrics: Optional mapping from display label to a metric. A value may be a | ||||||||||||||
| callable ``(left_expr, right_expr) -> pl.Expr`` or a | ||||||||||||||
| :class:`~diffly.metrics.Metric`. Each callable receives two | ||||||||||||||
| :class:`polars.Expr` referring to the left and right values of a single | ||||||||||||||
| column across all joined rows, and must return a scalar aggregation | ||||||||||||||
| expression. Bare callables are only computed for numerical columns; wrap | ||||||||||||||
| one in a :class:`~diffly.metrics.Metric` with a column selector to target | ||||||||||||||
| other column types (e.g. ``Metric(fn, selector=cs.all())``). | ||||||||||||||
| See :doc:`/api/metrics` for the full list of presets and the | ||||||||||||||
| :data:`~diffly.metrics.MetricFn` type. When ``None`` (default), no metrics | ||||||||||||||
| are computed; presets are not applied automatically. Prefer short labels — | ||||||||||||||
| the summary has a fixed width and many or long labels degrade rendering. | ||||||||||||||
| data_metrics: Optional mapping from display label to a data metric, | ||||||||||||||
| describing each dataset individually and rendered in the "Data | ||||||||||||||
| Inspection" section. A value may be a | ||||||||||||||
| :class:`~diffly.metrics.data.DataMetric` or a bare callable taking a | ||||||||||||||
| single column expression, which is wrapped in a | ||||||||||||||
| :class:`~diffly.metrics.data.DataMetric` applying to all columns. To | ||||||||||||||
| target other column types, construct the metric explicitly with a | ||||||||||||||
| column selector (e.g. ``DataMetric(fn, selector=cs.numeric())``). | ||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this applies not only to
Suggested change
|
||||||||||||||
| change_metrics: Optional mapping from display label to a change metric, | ||||||||||||||
| quantifying the change between the two sides and rendered as extra | ||||||||||||||
| columns in the "Columns" table. A value may be a | ||||||||||||||
| :class:`~diffly.metrics.change.ChangeMetric` or a bare callable taking a | ||||||||||||||
| pair of column expressions, which is wrapped in a | ||||||||||||||
| :class:`~diffly.metrics.change.ChangeMetric` applying to numerical | ||||||||||||||
| columns. To target other column types, construct the metric explicitly | ||||||||||||||
| with a column selector (e.g. ``ChangeMetric(fn, selector=cs.numeric())``). | ||||||||||||||
| See :doc:`/api/metrics` for the full list of presets. When ``None`` | ||||||||||||||
| (default), no metrics are computed; presets are not applied | ||||||||||||||
| automatically. Prefer short labels — the summary has a fixed width and | ||||||||||||||
| many or long labels degrade rendering. | ||||||||||||||
|
|
||||||||||||||
| Returns: | ||||||||||||||
| A summary which can be printed or written to a file. | ||||||||||||||
|
|
@@ -977,12 +987,14 @@ def summary( | |||||||||||||
| # NOTE: We're importing here to prevent circular imports | ||||||||||||||
| from .summary import Summary | ||||||||||||||
|
|
||||||||||||||
| resolved_metrics = ( | ||||||||||||||
| { | ||||||||||||||
| label: v if isinstance(v, Metric) else _make_numeric_metric(v) | ||||||||||||||
| for label, v in metrics.items() | ||||||||||||||
| } | ||||||||||||||
| if metrics is not None | ||||||||||||||
| resolved_data_metrics = ( | ||||||||||||||
| {label: _resolve_data_metric(v) for label, v in data_metrics.items()} | ||||||||||||||
| if data_metrics is not None | ||||||||||||||
| else None | ||||||||||||||
| ) | ||||||||||||||
| resolved_change_metrics = ( | ||||||||||||||
| {label: _resolve_change_metric(v) for label, v in change_metrics.items()} | ||||||||||||||
| if change_metrics is not None | ||||||||||||||
| else None | ||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
|
|
@@ -996,7 +1008,8 @@ def summary( | |||||||||||||
| right_name=right_name, | ||||||||||||||
| slim=slim, | ||||||||||||||
| hidden_columns=hidden_columns, | ||||||||||||||
| metrics=resolved_metrics, | ||||||||||||||
| data_metrics=resolved_data_metrics, | ||||||||||||||
| change_metrics=resolved_change_metrics, | ||||||||||||||
| ) | ||||||||||||||
|
|
||||||||||||||
| # ----------------------------------- UTILITIES ----------------------------------- # | ||||||||||||||
|
|
@@ -1239,3 +1252,11 @@ def _list_length_exprs( | |||||||||||||
| for e in _list_length_exprs(expr.struct[field.name], field.dtype) | ||||||||||||||
| ] | ||||||||||||||
| return [] | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| def _resolve_data_metric(v: DataMetricFn | DataMetric) -> DataMetric: | ||||||||||||||
| return v if isinstance(v, DataMetric) else DataMetric(fn=v) | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
| def _resolve_change_metric(v: ChangeMetricFn | ChangeMetric) -> ChangeMetric: | ||||||||||||||
| return v if isinstance(v, ChangeMetric) else ChangeMetric(fn=v) | ||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,50 +1,17 @@ | ||
| # Copyright (c) QuantCo 2025-2026 | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| """Metrics computed per column when generating a summary. | ||
|
|
||
| Two families are provided: | ||
|
|
||
| - Metrics in :mod:`~diffly.metrics.change` describe the change between numeric | ||
| columns itself by aggregating over ``right - left``. | ||
| - Metrics in :mod:`~diffly.metrics.data` describe the left and right datasets | ||
| individually, explaining how a change affects the data. | ||
| - :class:`~diffly.metrics.change.ChangeMetric`s in :mod:`~diffly.metrics.change` describe the change between | ||
| columns itself by aggregating over a combination of the columns (e.g., ``right - left``). | ||
| - :class:`~diffly.metrics.data.DataMetric`s in :mod:`~diffly.metrics.data` describe the left and right | ||
| datasets individually, explaining how a change affects the data. | ||
| """ | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from . import change, data | ||
| from ._common import Metric, MetricFn | ||
| from .change import ( | ||
| _make_numeric_metric, | ||
| max, | ||
| mean, | ||
| mean_absolute_deviation, | ||
| mean_relative_deviation, | ||
| median, | ||
| min, | ||
| quantile, | ||
| std, | ||
| ) | ||
|
|
||
| DEFAULT_METRICS: dict[str, MetricFn | Metric] = { | ||
| **change.DEFAULT_CHANGE_METRICS, | ||
| } | ||
| """The default preset metrics, consisting of the change default set.""" | ||
|
|
||
| __all__ = [ | ||
| "DEFAULT_METRICS", | ||
| "Metric", | ||
| "MetricFn", | ||
| "change", | ||
| "data", | ||
| "max", | ||
| "mean", | ||
| "mean_absolute_deviation", | ||
| "mean_relative_deviation", | ||
| "median", | ||
| "min", | ||
| "quantile", | ||
| "std", | ||
| "_make_numeric_metric", | ||
| ] | ||
| __all__ = ["change", "data"] |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.