fix: undefined LmhpFragmentationParams_t compilation error#17
Open
ScholliYT wants to merge 1 commit intoRAKWireless:RUI_5.0-branchfrom
Open
fix: undefined LmhpFragmentationParams_t compilation error#17ScholliYT wants to merge 1 commit intoRAKWireless:RUI_5.0-branchfrom
ScholliYT wants to merge 1 commit intoRAKWireless:RUI_5.0-branchfrom
Conversation
Contributor
|
Compiling for the RAK3172-T does not throw any errors with the standard configuration.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling current main without the
SUPPORT_FUOTAflag set results in an errorBecause this type is use which is only defined if
SUPPORT_FUOTAflag is set.https://github.com/RAKWireless/RAK-STM32-RUI/blob/main/cores/STM32WLE/component/service/lora/service_lora.c#L119-L128
This should also be checked on the new v5.0 branch (I did not check it yet).