Skip to content

Fix: fix and improve touch driver for stm32f407-atk-explorer #11136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LinuxMint-User wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: fix and improve touch driver for stm32f407-atk-explorer #11136

LinuxMint-User wants to merge 1 commit into from
+179 −19

Conversation

@LinuxMint-User
Copy link
Contributor

@LinuxMint-User LinuxMint-User commented Jan 13, 2026

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

修复 stm32f407-atk-explorer BSP 中 TFTLCD 电阻触摸屏驱动无法正确传递 LVGL 触摸释放事件导致无法操作控件的问题，并优化了触摸驱动对 LVGL 中滑动控件的支持。

你的解决方案是什么 (what is your solution)

在XPT2046触摸驱动中添加完整的状态机管理和坐标优化算法：

  1. 完整的事件状态机：

    • 添加触摸开始、移动、结束的完整状态跟踪
    • 正确发送LV_INDEV_STATE_PR（按下）和LV_INDEV_STATE_REL（释放）事件
    • 解决LVGL点击事件不触发的问题

  2. 滑动体验优化：

    • 坐标平滑滤波：5点移动平均算法，减少电阻屏坐标跳动
    • 移动阈值检测：3像素移动阈值，智能区分点击和滑动操作
    • 去抖动处理：防止误触，提高触摸精度
    • 智能释放检测：连续5次（5ms）无触摸数据视为释放

  3. 参数优化配置：

    #define HISTORY_SIZE 5                    // 历史坐标缓冲大小
static const int DEBOUNCE_COUNT = 2;      // 按下去抖动次数
static const int MIN_MOVE_DISTANCE = 3;   // 滑动检测阈值（像素）
static const int SMOOTHING_FACTOR = 2;    // 坐标平滑插值因子

此方案不修改RT-Thread框架结构，保持向后兼容，仅优化触摸驱动内部算法。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/stm32/stm32f407-atk-explorer
  • .config: 默认配置
    • 开启 Hardware Drivers Config -> Onboard Peripheral Drivers -> Enable ATK LCD
    • 开启 Hardware Drivers Config -> Onboard Peripheral Drivers -> Use LCD TOUCH (Default Res)
    • 开启 Hardware Drivers Config -> Onboard Peripheral Drivers -> Enable LVGL for LCD
    • 开启 Hardware Drivers Config -> Onboard Peripheral Drivers -> Enable LVGL demo
    • LVGL 版本为 8.3.11

验证结果：

  1. ✅ LVGL日历DEMO正常显示，触摸交互正常
  2. ✅ 按钮点击事件正确触发，有按下/释放视觉反馈
  3. ✅ 滑动手势识别准确
    ]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link

github-actions bot commented Jan 13, 2026

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：dev-1
  • 设置PR number为 \ Set the PR number to：11136
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 dev-1 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the dev-1 branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions
Copy link

github-actions bot commented Jan 13, 2026 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: Liang1795 hamburger-os wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-atk-explorer/.ci/attachconfig/onboard-lcd-touch.attach
  • bsp/stm32/stm32f407-atk-explorer/board/ports/touch/drv_touch_xpt.c
  • bsp/stm32/stm32f407-atk-explorer/board/ports/touch/drv_xpt2046_init.c

📊 Current Review Status (Last Updated: 2026-01-16 15:14 CST)

  • ⌛ Liang1795 Pending Review
  • ⌛ hamburger-os Pending Review
  • ⌛ wdfk-prog Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP: STM32 BSP related with ST/STM32 BSP labels Jan 13, 2026
@Rbb666 Rbb666 requested a review from Copilot January 15, 2026 05:23
Copilot AI reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes critical touch event handling bugs in the XPT2046 resistive touchscreen driver for the stm32f407-atk-explorer BSP and improves the touch sliding experience for LVGL applications.

Changes:

  • Fixed missing touch release event (LV_INDEV_STATE_REL) that prevented LVGL widgets from responding to clicks
  • Implemented coordinate smoothing with 5-point moving average filter to reduce resistive touchscreen jitter
  • Added complete state machine for touch events (press, move, release) with debounce logic
  • Corrected function return type from rt_ssize_t to rt_size_t in xpt2046_touch_readpoint
  • Added CI configuration files for automated testing of LCD and touch features

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
bsp/stm32/stm32f407-atk-explorer/board/ports/touch/drv_xpt2046_init.c Complete rewrite of touch event handling with state machine, coordinate filtering, and proper LVGL event states
bsp/stm32/stm32f407-atk-explorer/board/ports/touch/drv_touch_xpt.c Fixed return type of xpt2046_touch_readpoint function and formatting improvements
bsp/stm32/stm32f407-atk-explorer/.ci/attachconfig/onboard-lcd.attach Added CI configuration for LCD feature testing
bsp/stm32/stm32f407-atk-explorer/.ci/attachconfig/onboard-lcd-touch.attach Added CI configuration for touch feature testing

@LinuxMint-User LinuxMint-User force-pushed the dev-1 branch 2 times, most recently from fd077f1 to e4f7807 Compare January 16, 2026 07:04
@LinuxMint-User
Fix: fix xpt2046_touch_readpoint type error
146ba92 
Fix & Improve: fix touch event bug with LVGL

Fix touch event bug with LVGL.
Improve the touch sliding experience of resistive screens.

[ci][stm32f407] add lcd attach config CI check

Fix: minor modification

Fix format issue.

Fix Ci attach file.
@LinuxMint-User
Copy link
Contributor Author

LinuxMint-User commented Jan 16, 2026 •
edited
Loading

已修正代码格式与注释问题并修复Ci看护编译错误问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mysterywolf mysterywolf Awaiting requested review from mysterywolf mysterywolf is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LinuxMint-User