Skip to content

[libcpu][risc-v] Fix PLIC interrupt processing order#11305

Open
FurryAcetylCoA wants to merge 1 commit intoRT-Thread:masterfrom
FurryAcetylCoA:fix_plic
Open

[libcpu][risc-v] Fix PLIC interrupt processing order#11305
FurryAcetylCoA wants to merge 1 commit intoRT-Thread:masterfrom
FurryAcetylCoA:fix_plic

Conversation

@FurryAcetylCoA
Copy link
Copy Markdown

Description / 描述

This PR fixes the PLIC interrupt handling order in the RISC-V virt64 libcpu. The previous code called plic_complete before executing the interrupt handler, which violated the correct interrupt flow. According to Section 1.5 Interrupt Flow of the RISC-V Platform-Level Interrupt Controller Specification, the interrupt should be handled first and then completed.

本次 PR 修复了 RISC-V virt64 中的 PLIC 中断处理顺序。以往的代码在执行中断 handler 之前调用了 plic_complete。根据 RISC-V Platform-Level Interrupt Controller Specification 的 1.5. Interrupt Flow 节的说明,应当先运行 handler,然后再 complete。

Modified Files / 修改文件

  • libcpu/risc-v/virt64/plic.c: Fixed plic_handle_irq by moving plic_complete after the handler call.

@github-actions
Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix_plic
  • 设置PR number为 \ Set the PR number to:11305
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix_plic 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix_plic branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions bot added Arch: RISC-V BSP related with risc-v libcpu labels Mar 31, 2026
@github-actions
Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: libcpu_riscv

Reviewers: @Yaochenger

Changed Files (Click to expand)
  • libcpu/risc-v/virt64/plic.c

📊 Current Review Status (Last Updated: 2026-03-31 20:05 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v libcpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants