[docs][libcpu][arm][cortex-a] correct TLBIALL comments in start_gcc.S#11309
Merged
Rbb666 merged 1 commit intoRT-Thread:masterfrom Apr 3, 2026
Merged
[docs][libcpu][arm][cortex-a] correct TLBIALL comments in start_gcc.S#11309Rbb666 merged 1 commit intoRT-Thread:masterfrom
Rbb666 merged 1 commit intoRT-Thread:masterfrom
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
Rbb666
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
为什么提交这份PR (why to submit this PR)
libcpu/arm/cortex-a/start_gcc.S中 3 处mcr p15, 0, r0, c8, c7, 0的注释写成了ITLBIALL,与实际执行的 TLB invalidate-all 操作不一致。虽然该问题不会影响运行结果,但会在阅读启动流程、排查 MMU/TLB 初始化问题以及后续维护时造成误导,因此需要修正。你的解决方案是什么 (what is your solution)
将
init_cpu_mode、enable_mmu_page_table_early和rt_hw_mmu_switch中对应指令后的注释统一由ITLBIALL更正为TLBIALL,使注释与实际 CP15 指令语义保持一致。本次修改仅涉及注释,不改变汇编指令、寄存器访问顺序和运行时行为。根据《ARM Architecture Reference Manual ARMv7-A and ARMv7-R edition》中对相关 CP15 操作的定义,

mcr p15, 0, r0, c8, c7, 0对应的注释应为TLBIALL。相关手册截图如下:请提供验证的bsp和config (provide the config and bsp)
bsp/qemu-vexpress-a9.config,无需额外改动https://github.com/laidene/rt-thread/actions/workflows/manual_dist.yml当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up