Skip to content

[HUST CSE][libcpu][arm]fix irq mask/unmask vector bounds handling#11310

Open
Telecaster2147 wants to merge 1 commit intoRT-Thread:masterfrom
Telecaster2147:fix/libcpu-arm-irq-mask-bounds
Open

[HUST CSE][libcpu][arm]fix irq mask/unmask vector bounds handling#11310
Telecaster2147 wants to merge 1 commit intoRT-Thread:masterfrom
Telecaster2147:fix/libcpu-arm-irq-mask-bounds

Conversation

@Telecaster2147
Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

本 PR 修复多个 legacy ARM 端口的 rt_hw_interrupt_mask()/rt_hw_interrupt_umask() 直接使用 1 << vector操作中断屏蔽寄存器,但没有对 vector做边界校验。

当 vector 为负数或超出端口 MAX_HANDLERS 范围时,1 << vector会触发未定义行为,导致屏蔽/使能错误的中断位,严重时会引发不可预期行为或系统异常。由于 rt_hw_interrupt_mask/umask 是公开的硬件抽象接口,上层驱动/BSP 代码会直接传入 irq/irqno/vector,一旦配置或计算出错就可能触发该问题。

你的解决方案是什么 (what is your solution)

在受影响的 ARM 端口实现文件中增加统一的向量合法性检查,并在 rt_hw_interrupt_mask() 与 rt_hw_interrupt_umask() 入口处提前拒绝非法 vector:

本次提交覆盖以下文件,均为同一类问题的同一修复模式:

  • libcpu/arm/AT91SAM7S/interrupt.c
  • libcpu/arm/AT91SAM7X/interrupt.c
  • libcpu/arm/lpc24xx/interrupt.c
  • libcpu/arm/lpc214x/cpuport.c
  • libcpu/arm/s3c24x0/interrupt.c
  • libcpu/arm/s3c44b0/interrupt.c
  • libcpu/arm/sep4020/interrupt.c

请提供验证的bsp和config (provide the config and bsp)

  • BSP: 暂无,当前仅完成代码级复核;
  • .config: 无
  • action: 暂无

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:fix/libcpu-arm-irq-mask-bounds
  • 设置PR number为 \ Set the PR number to:11310
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 fix/libcpu-arm-irq-mask-bounds 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/libcpu-arm-irq-mask-bounds branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant