[HUST CSE][libcpu][arm]fix irq mask/unmask vector bounds handling#11310
Open
Telecaster2147 wants to merge 1 commit intoRT-Thread:masterfrom
Open
[HUST CSE][libcpu][arm]fix irq mask/unmask vector bounds handling#11310Telecaster2147 wants to merge 1 commit intoRT-Thread:masterfrom
Telecaster2147 wants to merge 1 commit intoRT-Thread:masterfrom
Conversation
|
👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。 🛠 操作步骤 | Steps
完成后,提交将自动更新至 如有问题欢迎联系我们,再次感谢您的贡献!💐 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
本 PR 修复多个 legacy ARM 端口的 rt_hw_interrupt_mask()/rt_hw_interrupt_umask() 直接使用 1 << vector操作中断屏蔽寄存器,但没有对 vector做边界校验。
当 vector 为负数或超出端口 MAX_HANDLERS 范围时,1 << vector会触发未定义行为,导致屏蔽/使能错误的中断位,严重时会引发不可预期行为或系统异常。由于 rt_hw_interrupt_mask/umask 是公开的硬件抽象接口,上层驱动/BSP 代码会直接传入 irq/irqno/vector,一旦配置或计算出错就可能触发该问题。
你的解决方案是什么 (what is your solution)
在受影响的 ARM 端口实现文件中增加统一的向量合法性检查,并在 rt_hw_interrupt_mask() 与 rt_hw_interrupt_umask() 入口处提前拒绝非法 vector:
本次提交覆盖以下文件,均为同一类问题的同一修复模式:
libcpu/arm/AT91SAM7S/interrupt.clibcpu/arm/AT91SAM7X/interrupt.clibcpu/arm/lpc24xx/interrupt.clibcpu/arm/lpc214x/cpuport.clibcpu/arm/s3c24x0/interrupt.clibcpu/arm/s3c44b0/interrupt.clibcpu/arm/sep4020/interrupt.c请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up