feat: Add a keyboard shortcut for displaying the contextual menu#9602
Open
feat: Add a keyboard shortcut for displaying the contextual menu#9602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Proposed Changes
This PR adds a keyboard shortcut (Ctrl/Cmd + Enter) for displaying the contextual menu for the currently focused item, assuming the currently focused item implements IContextMenu. It also addresses #8786 by adding a getter for the underlying
Menuinstance toBlockly.ContextMenu, which it uses to automatically highlight the first menu item in the contextual menu once it is displayed.Tests were LLM-generated from a specified list of testcases and manually reviewed and modified.