Skip to content

fix: Fix bug that could prevent dismissing field editors on Enter #9986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonfunko wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

fix: Fix bug that could prevent dismissing field editors on Enter #9986

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
846b6fc
fix: Fix bug that could prevent dismissing field editors on Enter
gonfunko Jun 12, 2026
b530dd6
chore: Remove errant logging
gonfunko Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/blockly/core/field_input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,9 @@ export abstract class FieldInput<T extends InputTypes> extends Field<
if (e.key === 'Enter') {
WidgetDiv.hideIfOwner(this);
dropDownDiv.hideWithoutAnimation();
// Prevent this from also being handled by the Enter keyboard shortcut,
// which can re-show the field editor after we just dismissed it.
e.stopPropagation();
} else if (e.key === 'Escape') {
this.setValue(
this.htmlInput_!.getAttribute('data-untyped-default-value'),
Expand Down
Loading