Skip to content

frollmedianFast: avoid reading uninitialised array #7589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MichaelChirico merged 1 commit into from
Jan 14, 2026
Merged

frollmedianFast: avoid reading uninitialised array #7589

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/froll.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1707,11 +1707,13 @@ void frollmedianFast(const double *x, uint64_t nx, ans_t *ans, int k, double fil
snprintf(end(ans->message[3]), 500, _("%s: 's[A] + s[B] == h' is not true\n"), "frollmedianFast");
return;
}*/
if (n[A]!=tail && m[A] == n[A]) {
n[A] = tail;
}
if (n[B]!=tail && m[B] == n[B]) {
n[B] = tail;
if (even) {
if (n[A]!=tail && m[A] == n[A]) {
n[A] = tail;
Copy link
Member Author

@aitap aitap Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm struggling to devise a test that would reach this line. The closest I've got was n[A] = m[A] = tail = 4 for frollmedian(c(1:4, rep(1,3)), 4).

}
if (n[B]!=tail && m[B] == n[B]) {
n[B] = tail;
}
}
ansv[j*k+i] = even ? MED2(A, B) : MED(A, B);
}
Expand Down
Loading