Merged
Conversation
kpamnany
force-pushed
the
kp-drop-edges
branch
from
18ea7f5 to
751cd99
Compare
kpamnany
force-pushed
the
kp-drop-edges
branch
from
30717a9 to
de3acc7
Compare
|
This PR is stale because it has been open 30 days with no activity. Comment or remove stale label, or this PR will be closed in 5 days. |
topolarity
approved these changes
Feb 5, 2026
topolarity
left a comment
topolarity
left a comment
There was a problem hiding this comment.
Not upstreamable in this form, but should be appropriate for frozen-world workflows.
Looks good to me!
| jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag); | ||
| loctag = jl_box_int32((int32_t)idx); | ||
| jl_array_ptr_1d_push(_jl_debug_method_invalidation, loctag); | ||
| if (jl_array_len(callee_ids) > 0) { |
There was a problem hiding this comment.
We've discussed this before, but just for posterity:
If you want this to be upstreamable, this should be a replaced with a "frozen world check" in the else branch. As is, this loads the code without checking that you did the "world dance" correctly, which could cause invalidated code to run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Applies during image generation (i.e. when using
--output-o). When--drop-edgesis specified, do not serialize edges into the image.Checklist
Requirements for merging:
port-to-*labels that don't apply.