-
Notifications
You must be signed in to change notification settings - Fork 86
Android build #1804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Android build #1804
Conversation
|
Changes:
|
|
Git History should be cleaned up (Some things should be squashed, so that some distinguish commits are there) |
58e0d92 to
1556dcc
Compare
1556dcc to
23ec296
Compare
fa9b143 to
e81e7d7
Compare
511ffbf to
18406ad
Compare
|
#1850 will be merged after its CI finishes. I think the last open issue here was the handling of a double-touch as double-click to close the window. So you can incorporate that (merge or rebase) and check the suggestion I just made. If it works in your tests with those then I'd say this is ready :-) |
18406ad to
bd724d1
Compare
maybe a proper rebase & squashing some of the commits to proper commits would be nice ;-) |
Is this ok? |
Flamefire
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer if every commit builds and is correctly formatted (to avoid unrelated changes in the next commit) and the last 2 commits are not "Updated to last commit [...]" as it isn't clear what that means. To which commit?
Also the fix in those could be squashed to the commit introducing the issue.
But the overall change looks good to me, so not a requirement also I'd suggest to rename the last 2 messages so the "last commit" part is clearer, maybe split if required.
But I'll let @Flow86 decide.
In case you want to fix the formatting, what I'd do is: Interactive rebase stopping on each commit, run make clangFormat and continue. On any conflict select the incoming change (i.e. next commit) and format again.
|
@Farmer-Markus Do you want to fix the commit messages? otherwise I'd just merge this. |
I'll fix it. I'm just very busy at the moment |
I'm working on recreating my android port of rttr.
Currently the game starts but failes to find any drivers.I would need an option to set a custom output path for the translation/data copying.Also an enviroment variable to set the path to the drivers or the game data (or both)
Also another problem is openGl.
On android only openGl-Es is available and I've used a translation library (gl4es) that works pretty well. But the SDL videodriver would need: 1. to link against gl4es and 2. the SDL_gl_getprocaddress to be replaced by the gl4es equivalent.
This could also be used to support devices like the raspberry pi.
Also I would implement basic touch controls which should also work on touchscreen laptops (thanks to sdl)
I know these would be some pretty big changes...