Skip to content

Conversation

@Farmer-Markus
Copy link
Contributor

@Farmer-Markus Farmer-Markus commented Oct 6, 2025

I'm working on recreating my android port of rttr.
Currently the game starts but failes to find any drivers.

I would need an option to set a custom output path for the translation/data copying.
Also an enviroment variable to set the path to the drivers or the game data (or both)

Also another problem is openGl.
On android only openGl-Es is available and I've used a translation library (gl4es) that works pretty well. But the SDL videodriver would need: 1. to link against gl4es and 2. the SDL_gl_getprocaddress to be replaced by the gl4es equivalent.
This could also be used to support devices like the raspberry pi.

Also I would implement basic touch controls which should also work on touchscreen laptops (thanks to sdl)

I know these would be some pretty big changes...

@Farmer-Markus
Copy link
Contributor Author

Farmer-Markus commented Oct 23, 2025

Changes:

  • Added 'natural' mouse mode & changed invert mouse setting to mouseMode (0:default, 1:inverted, 2:natural)
  • Changed invert mouse GUI setting (translations would need to be added/changed)
  • Added 'GL4ES' to RTTR_OPENGL cmake options & VideoSDL2 driver to support OpenGL-ES
  • Added 'RTTR_BUILD_LIB' cmake variable to build main executable as shared library (Needed to run on android)
  • Added Touch controls to VideoSDL2 driver (moving map with one finger, two finger zooming, double tap to close window)
  • Added allowing to control config paths using enviroment variables
  • Some minor changes to fix compiling with newer versions of gcc and clang

@Farmer-Markus Farmer-Markus marked this pull request as ready for review October 23, 2025 12:49
@Flow86
Copy link
Member

Flow86 commented Oct 24, 2025

Git History should be cleaned up (Some things should be squashed, so that some distinguish commits are there)

@Farmer-Markus Farmer-Markus force-pushed the android branch 3 times, most recently from fa9b143 to e81e7d7 Compare December 29, 2025 20:51
@Farmer-Markus Farmer-Markus force-pushed the android branch 2 times, most recently from 511ffbf to 18406ad Compare December 30, 2025 22:50
@Flamefire
Copy link
Member

#1850 will be merged after its CI finishes.

I think the last open issue here was the handling of a double-touch as double-click to close the window. So you can incorporate that (merge or rebase) and check the suggestion I just made. If it works in your tests with those then I'd say this is ready :-)

@Flow86
Copy link
Member

Flow86 commented Dec 31, 2025

If it works in your tests with those then I'd say this is ready :-)

maybe a proper rebase & squashing some of the commits to proper commits would be nice ;-)

@Farmer-Markus
Copy link
Contributor Author

maybe a proper rebase & squashing some of the commits to proper commits would be nice ;-)

Is this ok?

Copy link
Member

@Flamefire Flamefire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer if every commit builds and is correctly formatted (to avoid unrelated changes in the next commit) and the last 2 commits are not "Updated to last commit [...]" as it isn't clear what that means. To which commit?
Also the fix in those could be squashed to the commit introducing the issue.

But the overall change looks good to me, so not a requirement also I'd suggest to rename the last 2 messages so the "last commit" part is clearer, maybe split if required.

But I'll let @Flow86 decide.

In case you want to fix the formatting, what I'd do is: Interactive rebase stopping on each commit, run make clangFormat and continue. On any conflict select the incoming change (i.e. next commit) and format again.

@Flamefire Flamefire self-requested a review January 2, 2026 14:20
@Flamefire
Copy link
Member

@Farmer-Markus Do you want to fix the commit messages? otherwise I'd just merge this.

@Farmer-Markus
Copy link
Contributor Author

@Farmer-Markus Do you want to fix the commit messages? otherwise I'd just merge this.

I'll fix it. I'm just very busy at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants