Support git submodules in dirty. Used files detection not yet implemented#2
Draft
ypid wants to merge 1 commit intoRoboMagus:mainfrom
Draft
Support git submodules in dirty. Used files detection not yet implemented#2ypid wants to merge 1 commit intoRoboMagus:mainfrom
ypid wants to merge 1 commit intoRoboMagus:mainfrom
Conversation
ypid
changed the title
ypid
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the discussion from #1:
I currently don’t have the time to implemented used file detection for git submodules so I open this as draft PR. I am used to commit before I build so for me it is more natural that dirty reflects all files. But I like the idea of dirty being smarter. My idea long-term plan is to build ESPHome firmware in CI using a known (non-dirty) git state anyway so also for that, I don’t need the smartness. So I am not sure when I come around to finish this PR. Other people are welcome to finish it.