-
Notifications
You must be signed in to change notification settings - Fork 84
Configure Electron Forge packaging with ASAR unpack for all demos #1387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,8 +4,10 @@ | |
| "description": "Electron application demonstrating a two-joint manipulator visualization using rclnodejs and Three.js", | ||
| "main": "main.js", | ||
| "scripts": { | ||
| "start": "electron .", | ||
| "rebuild": "electron-rebuild" | ||
| "start": "electron-forge start", | ||
| "rebuild": "electron-rebuild", | ||
| "package": "electron-forge package", | ||
| "make": "electron-forge make" | ||
| }, | ||
| "keywords": [ | ||
| "Electron", | ||
|
|
@@ -20,10 +22,43 @@ | |
| ], | ||
| "license": "Apache-2.0", | ||
| "dependencies": { | ||
| "rclnodejs": "^1.5.1" | ||
| "rclnodejs": "^1.8.1", | ||
| "three": "^0.182.0" | ||
| }, | ||
| "devDependencies": { | ||
| "@electron/rebuild": "^3.7.2", | ||
| "electron": "^40.0.0" | ||
| "@electron-forge/cli": "^7.11.1", | ||
| "@electron-forge/maker-deb": "^7.11.1", | ||
| "@electron-forge/maker-rpm": "^7.11.1", | ||
| "@electron-forge/maker-squirrel": "^7.11.1", | ||
| "@electron-forge/maker-zip": "^7.11.1", | ||
| "@electron-forge/plugin-auto-unpack-natives": "^7.11.1", | ||
| "@electron-forge/plugin-fuses": "^7.11.1", | ||
| "@electron/rebuild": "^4.0.3", | ||
| "electron": "^40.1.0" | ||
| }, | ||
| "config": { | ||
| "forge": { | ||
| "packagerConfig": { | ||
| "asar": { | ||
| "unpack": "**/node_modules/rclnodejs/**" | ||
| } | ||
| }, | ||
| "makers": [ | ||
| { | ||
| "name": "@electron-forge/maker-squirrel", | ||
| "config": { | ||
| "name": "rclnodejs_manipulator_demo" | ||
| } | ||
| }, | ||
| { | ||
| "name": "@electron-forge/maker-zip", | ||
| "platforms": [ | ||
| "darwin", | ||
| "linux" | ||
| ] | ||
| } | ||
| ], | ||
|
Comment on lines
+46
to
+60
|
||
| "plugins": [] | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Three.js version (0.182.0) differs from the turtle_tf2 demo which uses 0.155.0. While both versions should work, consider using the same Three.js version across all demos for consistency, easier maintenance, and to avoid potential version-specific issues. The turtle_tf2 demo documentation at line 360 of its README specifically mentions version 0.155.0 for troubleshooting.