experimental: add getStatusTopic method to retrieve action status#1146
Open
ikwilnaarhuisman wants to merge 1 commit intoRobotWebTools:developfrom
Open
Conversation
Contributor
Author
|
I want to achieve the same functionality for the feedback topic, but I'm not sure how considering the message type differs: getFeedbackTopic() {
return new Topic<TFeedback>({
ros: this.ros,
name: `${this.name}/_action/feedback`,
messageType: "", // <<<< unknown! doesn't even work.
});
}
// OR
getFeedbackTopic(messageType: string) {
return new Topic<TFeedback>({
ros: this.ros,
name: `${this.name}/_action/feedback`,
messageType: messageType, // works, but feels dirty.
});
} |
Contributor
Author
|
@EzraBrooks What's your opinion on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1145 <- issue (which this PR fixes 50% of)
AFAIK the status of an action (aka the topic) is always defined in the same way:
/{ACTION_NAME}/_action/statuswith message typeaction_msgs/msg/GoalStatusArray. So instead of having to create the topic yourself, you can just get it directly from the action.This PR is experimental because I doubt that this is acceptable yet, but it works and gives a better idea than my vague description of the "missing functionality"