feat: add functions to retrieve ROS action details#986
feat: add functions to retrieve ROS action details#986harsh-pal-robotics wants to merge 1 commit intoRobotWebTools:developfrom
Conversation
EzraBrooks
left a comment
There was a problem hiding this comment.
Given that these are some fairly new APIs in rosapi, should we check the existence of the service before calling it, and tell the user their rosapi version might be too old?
hmmm not sure if its needed to throw an error, it will already trigger the error callback with the service does not exist message. But if we want to throw a message, we need to create a function first to check if a service available, and a ServiceNotAvailable error can be created and thrown. |
There was a problem hiding this comment.
Okay, I think it's fine to not add a check.
However, in the time since you opened this PR, I started adding types for the rosapi message types into the typescript portion of the codebase - could you add these message definitions there, to use in the JSDoc comments you added? Thanks!
Public API Changes
ROS class has new methods to retrieves information of action interfaces
Description
Added functions to retrieve the action goal, result, and feedback details.
Implementation in rosbridge: