Skip to content

Refined app.json a little#20

Open
AdwikaVishal wants to merge 1 commit intoRocketChat:mainfrom
AdwikaVishal:adwikavishal
Open

Refined app.json a little#20
AdwikaVishal wants to merge 1 commit intoRocketChat:mainfrom
AdwikaVishal:adwikavishal

Conversation

@AdwikaVishal
Copy link

Your JSON seems mostly fine, but there are a couple of things to check:

homepage and support URLs: These fields have just a slash (/) as the value. It might be a placeholder, but ensure they point to actual URLs if required.
Missing implementation: The "implements": [] field is empty. If your app implements any interfaces, you should list them here.
Permissions: You may want to review if all the permissions listed are required for your app, as excessive permissions can raise security concerns.

I made these changes

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Adwika Vishal seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@reetp
Copy link
Collaborator

reetp commented Feb 2, 2025

First you must fix this.

license/cla Pending — Contributor License Agreement is not signed yet.

After that I have no idea who will merge this. It was a GSoC project last year, not core.

@AdwikaVishal
Copy link
Author

First you must fix this.

Could you please just point me in the right direction as to how to do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants