Skip to content

fix: crop screen hidden behind navigation bar on iOS 26 - #7529

Open
Rohit3523 wants to merge 1 commit into
developfrom
fix/image-crop-library-picker
Open

fix: crop screen hidden behind navigation bar on iOS 26#7529
Rohit3523 wants to merge 1 commit into
developfrom
fix/image-crop-library-picker

Conversation

@Rohit3523

@Rohit3523 Rohit3523 commented Jul 29, 2026

Copy link
Copy Markdown
Member

Proposed changes

Bump react-native-image-crop-picker to fix crop screen UI hidden behind navigation bar on iOS 26.

Related PR: RocketChat/react-native-image-crop-picker#9

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-1445
Closes #7403

How to test or reproduce

  1. Open a room and tap the + button
  2. Select "Take a photo"
  3. Click a picture
  4. Verify the crop screen appears and no UI elements are hidden behind the navigation bar

Screenshots

Before After
ios_simulator_screenshot fix

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Updated the image selection and cropping component to a newer revision.
    • No user-facing features or behavior changes were introduced.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bf9b20ff-afcb-4290-885e-e78a5872a58b

📥 Commits

Reviewing files that changed from the base of the PR and between 7ae3df2 and 6e72841.

⛔ Files ignored due to path filters (2)
  • ios/Podfile.lock is excluded by !**/*.lock
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
📜 Recent review details
⏰ Context from checks skipped due to timeout. (4)
  • GitHub Check: Build Android / Build
  • GitHub Check: E2E Build iOS / ios-build
  • GitHub Check: E2E Build Android / android-build
  • GitHub Check: Build iOS / Build
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2026-02-05T13:55:00.974Z
Learnt from: Rohit3523
Repo: RocketChat/Rocket.Chat.ReactNative PR: 6930
File: package.json:101-101
Timestamp: 2026-02-05T13:55:00.974Z
Learning: In this repository, the dependency on react-native-image-crop-picker should reference the RocketChat fork (RocketChat/react-native-image-crop-picker) with explicit commit pins, not the upstream ivpusic/react-native-image-crop-picker. Update package.json dependencies (and any lockfile) to point to the fork URL and a specific commit, ensuring edge-to-edge Android fixes are included. This pattern should apply to all package.json files in the repo that declare this dependency.

Applied to files:

  • package.json
📚 Learning: 2026-05-07T17:47:14.516Z
Learnt from: diegolmello
Repo: RocketChat/Rocket.Chat.ReactNative PR: 7303
File: package.json:5-5
Timestamp: 2026-05-07T17:47:14.516Z
Learning: When reviewing pnpm `packageManager` version pins in any `package.json` (e.g., `"packageManager": "pnpm@<version>"`), don’t rely solely on web-search results to determine whether a version exists. For very recently published versions, cross-check the target version against the official pnpm release page (https://github.com/pnpm/pnpm/releases) and the npm registry page for pnpm (https://www.npmjs.com/package/pnpm) before flagging the pinned version as non-existent.

Applied to files:

  • package.json
🔇 Additional comments (1)
package.json (1)

102-102: LGTM!


Walkthrough

Updates react-native-image-crop-picker in package.json to reference a different Git commit hash.

Changes

Image cropper dependency update

Layer / File(s) Summary
Update image cropper revision
package.json
The react-native-image-crop-picker dependency now references a different Git commit hash.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: type: bug

Suggested reviewers: diegolmello

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the main change: updating the cropper dependency to fix the iOS 26 crop UI bug.
Linked Issues check ✅ Passed The dependency bump aligns with the linked iOS 26 cropper button issue and the described fix objective.
Out of Scope Changes check ✅ Passed The PR only changes the react-native-image-crop-picker dependency, with no unrelated code or config additions.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

Parsing error: Missing semicolon. (2:7)

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • NATIVE-1445: Request failed with status code 401

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Rohit3523
Rohit3523 temporarily deployed to approve_e2e_testing July 29, 2026 13:41 — with GitHub Actions Inactive
@Rohit3523
Rohit3523 marked this pull request as ready for review July 30, 2026 21:39
@github-actions

Copy link
Copy Markdown

iOS Build Available

Rocket.Chat 4.75.0.109466

@github-actions

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: image cropper rotate and aspect buttons unresponsive on iOS 26

1 participant