Cache currency symbol regex to improve parse performance#193
Merged
yukideluxe merged 4 commits intoRubyMoney:mainfrom Jul 23, 2025
Merged
Cache currency symbol regex to improve parse performance#193yukideluxe merged 4 commits intoRubyMoney:mainfrom
yukideluxe merged 4 commits intoRubyMoney:mainfrom
Conversation
sunny
reviewed
Jul 23, 2025
Co-authored-by: Sunny Ripert <sunny@sunfox.org>
yukideluxe
reviewed
Jul 23, 2025
Member
yukideluxe
left a comment
There was a problem hiding this comment.
Could we just remove the method and just use the constant here?
monetize/lib/monetize/parser.rb
Line 103 in 945da74
Member
|
also, I think the test failure is related 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cached the currency symbol regex in Parser to avoid recompiling it on every parse call, improving performance during repeated monetary parsing operations.