Fix issue where CRT HitTree in calibration tuples did not store run number [Develop]#861
Open
francescopoppi wants to merge 2 commits intodevelopfrom
Open
Fix issue where CRT HitTree in calibration tuples did not store run number [Develop]#861francescopoppi wants to merge 2 commits intodevelopfrom
francescopoppi wants to merge 2 commits intodevelopfrom
Conversation
…r were left uninitialized.
…d added TriggerTimestamp variable to DAQTree.
Contributor
|
I'm going through old PRs and it looks like this one never got approved. I realize the number of changes isn't trivial, but I hope your relative familiarity with the code will make things easier. Do you have time to review this PR or should I ask someone else? Would you like me to ask someone else to also review this PR? |
aheggest
approved these changes
Apr 3, 2026
Contributor
aheggest
left a comment
aheggest
left a comment
There was a problem hiding this comment.
I approve these changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Develop Version]
This PR fixes a bug where due to the fact CRTData were dropped from Stage0, running Stage1 did not fill run number and sub run number. This caused the usage of uninitialized variables. This error was spotted thanks to @mt82 who did consistency checks between productions.
On a side note, I cleaned the code from some bad indentation that made the code unreadable.
I also added Trigger Timestamp to the DAQTree, it should have been there since the beginning.