Skip to content

Fix bug in detsim with no YZ-simulation and add new related Stage0/Stage1/CAF fcls#865

Open
rtriozzi wants to merge 2 commits intodevelopfrom
feature/rtriozzi_NoYZSimChain
Open

Fix bug in detsim with no YZ-simulation and add new related Stage0/Stage1/CAF fcls#865
rtriozzi wants to merge 2 commits intodevelopfrom
feature/rtriozzi_NoYZSimChain

Conversation

@rtriozzi
Copy link
Copy Markdown

@rtriozzi rtriozzi commented Nov 7, 2025

This PR fixes some labels in the detsim fcl without the YZ-simulation. The downstream reconstruction chain had to be updated accordingly. This fix would enable producing testing samples much more quickly, as running the YZ-simulation on the grid got very hard lately. Currently opening this PR with fcls from v10_06_00_01p01 for discussion: I can provide similar fixes for develop, eventually. Thanks!

@rtriozzi rtriozzi self-assigned this Nov 7, 2025
@rtriozzi rtriozzi added the bug Something isn't working label Nov 7, 2025
@jas1005
Copy link
Copy Markdown
Contributor

jas1005 commented Apr 3, 2026

@gputnam and @cerati

I'm going through old PRs and it looks like this one never got approved. Do y'all have time to review this PR or should I ask someone else? I'm not tagging Tracy since he is a requested reviewer for many other PRs.

@rtriozzi
Copy link
Copy Markdown
Author

rtriozzi commented Apr 3, 2026

Hi Jacob, thanks for reaching out about this PR. I originally opened this PR for some bug fixes to our standard FHiCLs when not including the YZ simulation in the processing chain. This enabled developments on the reconstruction side (producing test samples with the YZ simulation is just prohibitive from a resources standpoint), so in a sense the workflow was already validated. Indeed, those FHiCLs refer to the v10_06_00_01p01 tag and it's unclear to me how to translate this to develop - it'll depend on many other PRs.

I think that #877 was meant to generalize this PR, so we'll have a chat with Mattia and check whether we can close this and open #877. We'll let you know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants