[Bug] NC Delta Rad Filter was not working. Copied working RES structure and changed to filter to NC Delta Rad #625
Conversation
| # modules | ||
| # | ||
|
|
||
| #include "filters_sbnd.fcl" |
There was a problem hiding this comment.
What filters is this removing?
There was a problem hiding this comment.
sbnd_finalstateparticlefilter, sbnd_ccnuefilter, and standard_crt_trig_filter. See https://github.com/SBNSoftware/sbndcode/blob/develop/sbndcode/Filters/fcls/filters_sbnd.fcl
There was a problem hiding this comment.
So this could well have been the cause I reckon, if a charged lepton is required in the FS and you have an NC interaction...
| @@ -108,5 +102,5 @@ outputs: | |||
| # override | |||
| # THIS DOES NOT WORK, CHECK! | |||
There was a problem hiding this comment.
Just being careful -- I'm guessing this is an obsolete comment? (i.e. the 0.5% pass rate is indeed all NC-RES events, they are in the TPC, etc..)?
There was a problem hiding this comment.
This is an obsolete comment. Note that while labeled as NCRES the actual filter being used in line 62 is for NCDeltaRAD
|
Looks good to me, I'll ping @miquelnebot from the Sim side to check this is all good! Thanks @seokjuchung |
Description
Please provide a detailed description of the changes this pull request introduces. If available, also link to a docdb link where the issue/change have been presented on/discussed.
The previous
prodgenie_nu_singleinteraction_tpc_NCDeltaRadiative_filtered_sbnd.fcldid not pass any events. This has been fixed by using the workingprodgenie_nu_singleinteraction_tpc_NCRadiativeResonant_filtered_sbnd.fclstructure and editing the Resonant filter to the NCDeltaRadiative filter.This working version has a passing rate of 0.5%.
This PR is related not related to an open issue / project
No CAF format change
Does not require different PR