Skip to content

Conversation

@URAYUSHJAIN
Copy link
Contributor

Description

Please include a brief description of the changes introduced by this pull request.

Related Issue

If this pull request addresses or resolves an existing issue, please reference it here.

Proposed Changes

Outline the changes made in this pull request and explain their purpose.

Checklist

  • I have tested these changes locally.
  • My code follows the project's coding style guidelines.
  • I have reviewed my own code to ensure quality.
  • Unnecessary comments were removed.

Additional Notes

Add any additional notes or context about this pull request.

- Added contextually relevant emojis to all headings in CONTRIBUTING.md
- Emojis include: 🤝 for main heading, 🌟 for ways to contribute, 🚀 for getting started
- Added 📝 for code style, 🛠️ for formatting tools, 🪝 for commit hooks, 💬 for feedback
- Improves visual appeal and readability of the contributing guide

Closes SalamLang#1094
- Created .jscpd.json config file to handle legitimate code patterns
- Set higher threshold (50) and minLines (10) to reduce false positives
- Ignored generated AST and utility function patterns that are intentionally similar
- Excluded common C boilerplate patterns like create/destroy/json/log functions
- Configured appropriate ignore patterns for header guards and null checks
- Addresses duplicate code detection issues in Super-Linter workflow

Closes SalamLang#1092
- Address reviewer feedback from @jbampton
- Keep PR focused on single issue (SalamLang#1094 - emoji in contributing guide)
- JSCPD configuration should be handled in separate PR for issue SalamLang#1092
- Added Ruff configuration in pyproject.toml with Black-compatible settings
- Configured Ruff as primary Python formatter (line-length=88, double quotes)
- Updated super-linter.yml to use Ruff instead of Black for consistency
- Fixed Python linting issues: removed unused variables in generate_files.py
- Fixed f-string escape sequence compatibility issue in update-build.py
- All Python files now pass Ruff formatting and linting checks

Ruff provides faster formatting and linting than Black while maintaining compatibility.

Closes SalamLang#1080
@github-actions github-actions bot added documentation Improvements or additions to documentation repo github labels Oct 2, 2025
@jbampton jbampton self-assigned this Oct 2, 2025
@jbampton jbampton added this to the Salam Hacktoberfest milestone Oct 2, 2025
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes to the contributing guide

@jbampton jbampton changed the title Issue #1080 Super-Linter configure PYTHON_RUFF_FORMAT Oct 2, 2025
@jbampton jbampton linked an issue Oct 2, 2025 that may be closed by this pull request
@jbampton
Copy link
Member

jbampton commented Oct 2, 2025

image

@github-actions github-actions bot removed the documentation Improvements or additions to documentation label Oct 2, 2025
@jbampton jbampton marked this pull request as draft October 2, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants