clean up unused Python code and pass vulture pre-commit checks

[BDadmehr0]

#1075

• removed unused variables flagged by vulture
• simplified header guard regeneration logic
• ensured pre-commit vulture hook runs cleanly

[gemini-code-assist]

Summary of Changes

Hello @BDadmehr0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality and maintaining a clean codebase by addressing unused Python code and refining development workflows. It specifically removes dead code identified by the vulture tool, ensuring that the pre-commit checks for vulture pass consistently. Additionally, the changes include a simplification of the header guard regeneration logic within a Python script, contributing to overall code maintainability.

Highlights

• Code Cleanup: Removed unused Python variables that were flagged by the vulture static analysis tool, improving code cleanliness and reducing potential clutter.
• Logic Simplification: Simplified the internal logic within the clean_and_regenerate_guard function in generate_files.py by removing unnecessary variables.
• Pre-commit Configuration: Updated the .pre-commit-config.yaml to correctly configure the vulture hook, ensuring it runs cleanly and effectively scans the project for dead code.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully cleans up unused Python code and configures the vulture pre-commit hook. The changes simplify the codebase as intended. However, I've identified a pre-existing critical issue in the header guard regeneration logic in generate_files.py. The simplified code retains a bug that causes file content to be deleted. My review includes a detailed comment on this issue.

[jbampton]

/gemini review

[gemini-code-assist]

Code Review

This pull request cleans up unused variables in generate_files.py and correctly configures the vulture pre-commit hook to scan the entire project. While the cleanup is good, I've identified a pre-existing critical bug in the header guard regeneration logic that this PR does not address. The current logic will erroneously delete all content within header guards, leading to data loss. I have provided a specific comment and suggestion to fix this critical issue.

[jbampton]

/gemini review

[gemini-code-assist]

Code Review

This pull request does a good job of cleaning up unused code and configuring the vulture pre-commit hook. The simplification of the header guard regeneration logic in generate_files.py is a good intention and fixes a bug where file content was being deleted. However, the new logic introduces a different bug related to handling nested preprocessor directives, which could lead to incorrect file generation. I've provided a detailed comment and a suggested fix for this issue.

[BDadmehr0]

@jbampton pls review this pr thanks

[jbampton]

Did you run the Python file ?

[BDadmehr0]

run and regenerated .h files @jbampton

[BaseMax]

I like the idea of this PR.

[BaseMax]

Just one question, it automatically check to run trim on file content to remove empty whitespace lines from top and bottom of the files?
And we need to force to have a \n at end of files.

@jbampton What do you think?
cc @BDadmehr0

[BDadmehr0]

Just one question, it automatically check to run trim on file content to remove empty whitespace lines from top and bottom of the files? And we need to force to have a \n at end of files.

@jbampton What do you think? cc @BDadmehr0

Not exactly — it trims content inside the guard using .strip(), so top/bottom empty lines are mostly removed, and it always ends with a \n. But it doesn’t explicitly clean leading/trailing blank lines before rebuilding the file.
With a small update around L55
, it could safely trim those lines