fix: allow LEFT JOIN to produce None for nested models

[denyszhak]

PR Info

• Closes FromQueryResult fails when having nested Option<Model> #2617

Bug Fixes

When using LEFT JOIN with a nested Option<Model>, code tried to read the missing
related row as if it were always present. This caused a type error instead of simply
returning None.

This change makes nested optional models behave normal by treating
all-null fields as a missing record.

Testing

Added test that validates the fix.

[tyt2y3]

the test case failed, any ideas?

thread 'from_query_result_left_join_with_optional_model_does_not_exist' (9460) panicked at tests/from_query_result_tests.rs:108:10:
succeeds to get the result: Type("A null value was encountered while decoding \"id\"")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

my current understanding: if the parent object is Option<Model>, then it effectively made all children fields Option<T>.
but if a struct has 2 required fields, we can only construct a model if all 2 required fields are Some.
is my understanding correct?

[denyszhak]

the test case failed, any ideas?

thread 'from_query_result_left_join_with_optional_model_does_not_exist' (9460) panicked at tests/from_query_result_tests.rs:108:10:
succeeds to get the result: Type("A null value was encountered while decoding \"id\"")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

my current understanding: if the parent object is Option<Model>, then it effectively made all children fields Option<T>. but if a struct has 2 required fields, we can only construct a model if all 2 required fields are Some. is my understanding correct?

Looking into this

[denyszhak]

@tyt2y3
The query had two columns named id (from cake and bakery), so the lookup found the wrong one. I prefixed one of them so could you please rerun the tests?

As to your understanding - correct, that's what it does.

[tyt2y3]

Awesome!

[github-actions]

🎉 Released In 2.0.0-rc.29 🎉

Huge thanks for the contribution!
This feature has now been released, so it's a great time to upgrade.
Show some love with a ⭐ on our repo, every star counts!